summaryrefslogtreecommitdiffstats
path: root/utils.cpp
Commit message (Collapse)AuthorAgeFilesLines
* clang-format: Update to match docs repoGunnar Mills2018-10-081-13/+11
| | | | | | | | | Update the .clang-format file and run clang-format-6.0. This .clang-format matches the example one in https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#clang-formatting Change-Id: Ic2c462525eb27b8295c2b298871e04268d93faf2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Throw runtime_error instead of MethodErorLei YU2018-09-121-28/+21
| | | | | | | | | | | As suggested, when error occurs in getService/getProperty, it means runtime error, so the code is better to throw std::runtime_error instead of a sdbusplus exception. Tested: Build the code correctly. Change-Id: Iddca72ac1fdd07ed6b731b6509eebbfa9d2579d3 Signed-off-by: Lei YU <mine260309@gmail.com>
* Follow secure coding standards for interactions with the mapperEd Tanous2018-05-091-3/+6
| | | | | | | | | | | | | | | | | This patchset updates phosphor-time-manager to follow secure coding guidelines when interacting with the mapper. Specifically, it replaces uses of std::map with std::vector<std::pair<>>, which should net some small performance wins. This change also causes time-manager to properly enumerate each response. Tested-By: Built with changeset, and verified via d-feet that /xyz/openbmc_project/time/host and /xyz/openbmc_project/time/bmc were present, and verified reading of the "Elapsed" parameter returned the expected time result. Change-Id: If4329d533641595cf0b50c4e50e2dda69b299f52 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
* Use time mode owner enums in dbus interfaceLei YU2017-10-161-78/+6
| | | | | | | | | | | Dbus interface defines time mode owners in xyz::openbmc_project::Time. Use the enums from the interface instead of repo defined enums and use the generated code to do convertions between strings and enums. Update unit tests accordingly. Change-Id: Ic304aa3b4137375d208bb1702e0f64df512fc5a0 Signed-off-by: Lei YU <mine260309@gmail.com>
* Use elog to throw exceptionsLei YU2017-10-161-22/+34
| | | | | | | Use elog to throw exceptions and update unit tests Change-Id: I338ded4403b3b559a84da311eda5ee15e712569a Signed-off-by: Lei YU <mine260309@gmail.com>
* Use mapper to find service nameLei YU2017-10-161-0/+39
| | | | | | | | Use objectMapper to find the service name instead of using hard-coded service name. Change-Id: If436c65d9a9a4942eaf30ea20bc7b85e3e7694c1 Signed-off-by: Lei YU <mine260309@gmail.com>
* Implement mode/owner and string conversionsLei YU2017-10-161-0/+107
Move Manager::convertToMode() to utils::strToMode(); Move Manager::convertToOwner() to utils::strToOwner(); Add utils::modeToStr() and utils::ownerToStr(); Adjust and add unit tests. Change-Id: Ied35d0e732c477017e1b2db1a3464b0425b12387 Signed-off-by: Lei YU <mine260309@gmail.com>
OpenPOWER on IntegriCloud