summaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2018-10-30 11:24:40 -0700
committerPatrick Venture <venture@google.com>2018-10-30 11:35:34 -0700
commit7af157b10ef4c1a0d09be0e310825909ca630cd0 (patch)
tree25b93febae7ec183587e9cc99a89a88ba2855e77 /test
parent34ddc90293c242b4f946709495ced2c0af3cd792 (diff)
downloadphosphor-pid-control-7af157b10ef4c1a0d09be0e310825909ca630cd0.tar.gz
phosphor-pid-control-7af157b10ef4c1a0d09be0e310825909ca630cd0.zip
style: function names should be lower camel
Fix function names to be lower camel. Change-Id: I145e1f4c03d7740bc1525dcffbdce2f78fd61075 Signed-off-by: Patrick Venture <venture@google.com>
Diffstat (limited to 'test')
-rw-r--r--test/dbus_passive_unittest.cpp8
-rw-r--r--test/util_unittest.cpp20
2 files changed, 14 insertions, 14 deletions
diff --git a/test/dbus_passive_unittest.cpp b/test/dbus_passive_unittest.cpp
index 777a623..6826ce1 100644
--- a/test/dbus_passive_unittest.cpp
+++ b/test/dbus_passive_unittest.cpp
@@ -202,7 +202,7 @@ TEST_F(DbusPassiveTestObj, VerifyHandlesDbusSignal)
.WillOnce(Return(0)) /* std::pair */
.WillOnce(Return(0)); /* std::map */
- int rv = HandleSensorValue(msg, passive);
+ int rv = handleSensorValue(msg, passive);
EXPECT_EQ(rv, 0); // It's always 0.
ReadReturn r = passive->read();
@@ -272,7 +272,7 @@ TEST_F(DbusPassiveTestObj, VerifyIgnoresOtherPropertySignal)
.WillOnce(Return(0)) /* std::pair */
.WillOnce(Return(0)); /* std::map */
- int rv = HandleSensorValue(msg, passive);
+ int rv = handleSensorValue(msg, passive);
EXPECT_EQ(rv, 0); // It's always 0.
ReadReturn r = passive->read();
@@ -346,7 +346,7 @@ TEST_F(DbusPassiveTestObj, VerifyCriticalThresholdAssert)
.WillOnce(Return(0)) /* std::pair */
.WillOnce(Return(0)); /* std::map */
- int rv = HandleSensorValue(msg, passive);
+ int rv = handleSensorValue(msg, passive);
EXPECT_EQ(rv, 0); // It's always 0.
bool failed = passive->getFailed();
EXPECT_EQ(failed, true);
@@ -421,7 +421,7 @@ TEST_F(DbusPassiveTestObj, VerifyCriticalThresholdDeassert)
.WillOnce(Return(0)) /* std::pair */
.WillOnce(Return(0)); /* std::map */
- int rv = HandleSensorValue(msg, passive);
+ int rv = handleSensorValue(msg, passive);
EXPECT_EQ(rv, 0); // It's always 0.
bool failed = passive->getFailed();
EXPECT_EQ(failed, false);
diff --git a/test/util_unittest.cpp b/test/util_unittest.cpp
index 6fe77b2..6e5e548 100644
--- a/test/util_unittest.cpp
+++ b/test/util_unittest.cpp
@@ -9,14 +9,14 @@ TEST(UtilTest, WriteTypeEmptyString_ReturnsNONE)
{
// Verify it responds to an empty string.
- EXPECT_EQ(IOInterfaceType::NONE, GetWriteInterfaceType(""));
+ EXPECT_EQ(IOInterfaceType::NONE, getWriteInterfaceType(""));
}
TEST(UtilTest, WriteTypeNonePath_ReturnsNONE)
{
// Verify it responds to a path of "None"
- EXPECT_EQ(IOInterfaceType::NONE, GetWriteInterfaceType("None"));
+ EXPECT_EQ(IOInterfaceType::NONE, getWriteInterfaceType("None"));
}
TEST(UtilTest, WriteTypeSysfs_ReturnsSYSFS)
@@ -24,7 +24,7 @@ TEST(UtilTest, WriteTypeSysfs_ReturnsSYSFS)
// Verify the sysfs type is determined with an expected path
std::string path = "/sys/devices/asfdadsf";
- EXPECT_EQ(IOInterfaceType::SYSFS, GetWriteInterfaceType(path));
+ EXPECT_EQ(IOInterfaceType::SYSFS, getWriteInterfaceType(path));
}
TEST(UtilTest, WriteTypeUnknown_ReturnsUNKNOWN)
@@ -32,21 +32,21 @@ TEST(UtilTest, WriteTypeUnknown_ReturnsUNKNOWN)
// Verify it reports unknown by default.
std::string path = "/xyz/openbmc_project";
- EXPECT_EQ(IOInterfaceType::UNKNOWN, GetWriteInterfaceType(path));
+ EXPECT_EQ(IOInterfaceType::UNKNOWN, getWriteInterfaceType(path));
}
TEST(UtilTest, ReadTypeEmptyString_ReturnsNONE)
{
// Verify it responds to an empty string.
- EXPECT_EQ(IOInterfaceType::NONE, GetReadInterfaceType(""));
+ EXPECT_EQ(IOInterfaceType::NONE, getReadInterfaceType(""));
}
TEST(UtilTest, ReadTypeNonePath_ReturnsNONE)
{
// Verify it responds to a path of "None"
- EXPECT_EQ(IOInterfaceType::NONE, GetReadInterfaceType("None"));
+ EXPECT_EQ(IOInterfaceType::NONE, getReadInterfaceType("None"));
}
TEST(UtilTest, ReadTypeExternalSensors_ReturnsEXTERNAL)
@@ -54,7 +54,7 @@ TEST(UtilTest, ReadTypeExternalSensors_ReturnsEXTERNAL)
// Verify it responds to a path that represents a host sensor.
std::string path = "/xyz/openbmc_project/extsensors/temperature/fleeting0";
- EXPECT_EQ(IOInterfaceType::EXTERNAL, GetReadInterfaceType(path));
+ EXPECT_EQ(IOInterfaceType::EXTERNAL, getReadInterfaceType(path));
}
TEST(UtilTest, ReadTypeOpenBMCSensor_ReturnsDBUSPASSIVE)
@@ -62,7 +62,7 @@ TEST(UtilTest, ReadTypeOpenBMCSensor_ReturnsDBUSPASSIVE)
// Verify it responds to a path that represents a dbus sensor.
std::string path = "/xyz/openbmc_project/sensors/fan_tach/fan1";
- EXPECT_EQ(IOInterfaceType::DBUSPASSIVE, GetReadInterfaceType(path));
+ EXPECT_EQ(IOInterfaceType::DBUSPASSIVE, getReadInterfaceType(path));
}
TEST(UtilTest, ReadTypeSysfsPath_ReturnsSYSFS)
@@ -70,7 +70,7 @@ TEST(UtilTest, ReadTypeSysfsPath_ReturnsSYSFS)
// Verify the sysfs type is determined with an expected path
std::string path = "/sys/devices/asdf/asdf0";
- EXPECT_EQ(IOInterfaceType::SYSFS, GetReadInterfaceType(path));
+ EXPECT_EQ(IOInterfaceType::SYSFS, getReadInterfaceType(path));
}
TEST(UtilTest, ReadTypeUnknownDefault_ReturnsUNKNOWN)
@@ -78,5 +78,5 @@ TEST(UtilTest, ReadTypeUnknownDefault_ReturnsUNKNOWN)
// Verify it reports unknown by default.
std::string path = "asdf09as0df9a0fd";
- EXPECT_EQ(IOInterfaceType::UNKNOWN, GetReadInterfaceType(path));
+ EXPECT_EQ(IOInterfaceType::UNKNOWN, getReadInterfaceType(path));
}
OpenPOWER on IntegriCloud