diff options
| author | Patrick Venture <venture@google.com> | 2018-10-26 17:55:08 -0700 |
|---|---|---|
| committer | Patrick Venture <venture@google.com> | 2018-11-08 17:19:15 +0000 |
| commit | a65e30df5d348337ae0b6afe3f800473117853dd (patch) | |
| tree | b9618fbae91c629f56145c6e49bdaa9b2ac10dfb /socket_channel.hpp | |
| parent | a34c2ab27d7ee8dfe661e02e7dadc56ff707db80 (diff) | |
| download | phosphor-net-ipmid-a65e30df5d348337ae0b6afe3f800473117853dd.tar.gz phosphor-net-ipmid-a65e30df5d348337ae0b6afe3f800473117853dd.zip | |
style: cppcheck cleanup
[command/guid.cpp:37]: (style) The scope of the variable 'rc' can be
reduced.
[socket_channel.hpp:44]: (performance) Variable 'timeout' is assigned
in constructor body. Consider performing initialization in
initialization list.
[sd_event_loop.cpp:107]: (style) The scope of the variable 'instance'
can be reduced.
[sd_event_loop.cpp:108]: (style) The scope of the variable 'rc' can be
reduced.
[sd_event_loop.cpp:142]: (style) The scope of the variable 'instance'
can be reduced.
[sd_event_loop.cpp:304]: (style) The scope of the variable 'rc' can be
reduced.
Change-Id: Id090cb217ea7ed9019f1b8d39ebebd6bb73113b1
Signed-off-by: Patrick Venture <venture@google.com>
Diffstat (limited to 'socket_channel.hpp')
| -rw-r--r-- | socket_channel.hpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/socket_channel.hpp b/socket_channel.hpp index 8a2edce..4b10b9a 100644 --- a/socket_channel.hpp +++ b/socket_channel.hpp @@ -38,10 +38,9 @@ class Channel * * @return None */ - Channel(int insockfd, timeval& inTimeout) + Channel(int insockfd, timeval& inTimeout) : + sockfd(insockfd), timeout(inTimeout) { - sockfd = insockfd; - timeout = inTimeout; } /** |
