summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2019-02-13 14:57:01 -0800
committerTom Joseph <tomjoseph@in.ibm.com>2019-02-16 00:41:59 +0000
commit27ebe584bbe4530c6a68bcfe06e0eb15217f16b7 (patch)
treefc348a32ea20a6ef879d9a45f0c023098d7422d0
parentdb9f8e739ad9f4a59123b63900a5577e95f3ce18 (diff)
downloadphosphor-net-ipmid-27ebe584bbe4530c6a68bcfe06e0eb15217f16b7.tar.gz
phosphor-net-ipmid-27ebe584bbe4530c6a68bcfe06e0eb15217f16b7.zip
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: I9222c872ae76c7fce1d05fde9fcbf14563fda447 Signed-off-by: Patrick Venture <venture@google.com>
-rw-r--r--configure.ac6
1 files changed, 3 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac
index 2f773c4..f030599 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,9 +43,9 @@ AX_APPEND_COMPILE_FLAGS([-Wall -Werror], [CXXFLAGS])
# Checks for libraries.
PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221])
PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.0.2g], ,[AC_MSG_ERROR([can't find openssl libcrypto])])
-PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],, [AC_MSG_ERROR([Could not find phosphor-logging...openbmc/phosphor-logging package required])])
-PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],, AC_MSG_ERROR(["Requires sdbusplus package."]))
-PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces],, [AC_MSG_ERROR([Could not find phosphor-dbus-interfaces...openbmc/phosphor-dbus-interfaces package required])])
+PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging])
+PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus])
+PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces])
AC_CHECK_LIB([mapper], [mapper_get_service], ,[AC_MSG_ERROR([Could not find libmapper...openbmc/phosphor-objmgr package required])])
# Checks for header files.
OpenPOWER on IntegriCloud