diff options
author | Andrew Jeffery <andrew@aj.id.au> | 2018-03-26 11:16:05 +1030 |
---|---|---|
committer | Andrew Jeffery <andrew@aj.id.au> | 2018-04-04 07:56:23 +0000 |
commit | 7c5a1091903d5e0959b1ab48211aa187170eaacf (patch) | |
tree | 9a52e8599b61152cb152be5e69e53a6b9e6385db /test | |
parent | 3da0de69628d1341e38608067a9f5198a1e35954 (diff) | |
download | phosphor-mboxd-7c5a1091903d5e0959b1ab48211aa187170eaacf.tar.gz phosphor-mboxd-7c5a1091903d5e0959b1ab48211aa187170eaacf.zip |
test: vpnor: Add create_write_window_ro_partition
The virtual PNOR implementation enforces the read-only attribute of
partitions out of the box. This causes trouble when the host requests a
write window over a read-only partition, as the flush command will fail.
Further, by design, we have open-implies-close-implies-flush semantics,
which means once a flush fails, any subsequent request to open a window
also fails.
We want the daemon to deny attempts to open write windows over a
read-only partition during the CREATE_WRITE_WINDOW request, to avoid
the cascading failures later on.
Change-Id: Ib6bec3d34a8a47e517088dd504f7a74641882f5d
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Diffstat (limited to 'test')
-rw-r--r-- | test/vpnor/Makefile.am.include | 18 | ||||
-rw-r--r-- | test/vpnor/create_write_window_ro_partition.cpp | 64 |
2 files changed, 81 insertions, 1 deletions
diff --git a/test/vpnor/Makefile.am.include b/test/vpnor/Makefile.am.include index ed637bc..2820b25 100644 --- a/test/vpnor/Makefile.am.include +++ b/test/vpnor/Makefile.am.include @@ -289,6 +289,19 @@ test_vpnor_create_read_window_remap_SOURCES = \ test_vpnor_create_read_window_remap_LDFLAGS = $(OESDK_TESTCASE_FLAGS) test_vpnor_create_read_window_remap_LDADD = $(VPNOR_LDADD) +test_vpnor_create_write_window_ro_partition_SOURCES = \ + $(TEST_MBOX_VPNOR_SRCS) $(TEST_MOCK_SRCS) \ + mboxd_msg.c \ + mboxd_windows.c \ + mboxd_lpc.c \ + mboxd_lpc_virtual.cpp \ + mboxd_pnor_partition_table.cpp \ + mboxd_flash_virtual.cpp \ + pnor_partition.cpp \ + %reldir%/create_write_window_ro_partition.cpp +test_vpnor_create_write_window_ro_partition_LDFLAGS = $(OESDK_TESTCASE_FLAGS) +test_vpnor_create_write_window_ro_partition_LDADD = $(VPNOR_LDADD) + if VIRTUAL_PNOR_ENABLED check_PROGRAMS += \ %reldir%/create_pnor_partition_table \ @@ -315,5 +328,8 @@ check_PROGRAMS += \ %reldir%/write_patch_resize \ %reldir%/dump_flash \ %reldir%/create_read_window_size \ - %reldir%/create_read_window_remap + %reldir%/create_read_window_remap \ + %reldir%/create_write_window_ro_partition + +XFAIL_TESTS += %reldir%/create_write_window_ro_partition endif diff --git a/test/vpnor/create_write_window_ro_partition.cpp b/test/vpnor/create_write_window_ro_partition.cpp new file mode 100644 index 0000000..e09ac69 --- /dev/null +++ b/test/vpnor/create_write_window_ro_partition.cpp @@ -0,0 +1,64 @@ +// SPDX-License-Identifier: Apache-2.0 +// Copyright (C) 2018 IBM Corp. + +#include <assert.h> + +#include "config.h" +#include "mboxd_pnor_partition_table.h" + +extern "C" { +#include "test/mbox.h" +#include "test/system.h" +} + +#include "test/vpnor/tmpd.hpp" + +const std::string toc[] = { + "partition01=HBB,00001000,00002000,80,ECC,READONLY", +}; + +static const auto BLOCK_SIZE = 4096; +static const auto MEM_SIZE = BLOCK_SIZE * 2; +static const auto ERASE_SIZE = BLOCK_SIZE; +static const auto N_WINDOWS = 1; +static const auto WINDOW_SIZE = BLOCK_SIZE; + +static const uint8_t get_info[] = {0x02, 0x00, 0x02, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00}; + +// offset 0x100 and size 6 +static const uint8_t create_write_window[] = { + 0x06, 0x01, 0x01, 0x00, 0x01, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + +static const uint8_t response[] = {0x06, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x07}; + +namespace test = openpower::virtual_pnor::test; + +int main() +{ + struct mbox_context *ctx; + + system_set_reserved_size(MEM_SIZE); + system_set_mtd_sizes(MEM_SIZE, ERASE_SIZE); + + ctx = mbox_create_test_context(N_WINDOWS, WINDOW_SIZE); + + test::VpnorRoot root(ctx, toc, BLOCK_SIZE); + + init_vpnor_from_paths(ctx); + + int rc = mbox_command_dispatch(ctx, get_info, sizeof(get_info)); + assert(rc == 1); + + rc = mbox_command_dispatch(ctx, create_write_window, + sizeof(create_write_window)); + assert(rc == 7); + + rc = mbox_cmp(ctx, response, sizeof(response)); + assert(rc == 0); + + return rc; +} |