diff options
author | Patrick Venture <venture@google.com> | 2019-02-13 15:21:57 -0800 |
---|---|---|
committer | Patrick Venture <venture@google.com> | 2019-02-13 15:21:57 -0800 |
commit | 5bab7c49ef95709f37ac2cc5a4291b95003a9cf8 (patch) | |
tree | bfd7159def5f11c16d2e7955b995efba96318f43 | |
parent | 9ed627ca50700ca99e4a18940a8b62bccd25236f (diff) | |
download | phosphor-mboxbridge-5bab7c49ef95709f37ac2cc5a4291b95003a9cf8.tar.gz phosphor-mboxbridge-5bab7c49ef95709f37ac2cc5a4291b95003a9cf8.zip |
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: Ide33a6c676d6b4db07a10aeb35e5076f9b3aeb91
Signed-off-by: Patrick Venture <venture@google.com>
-rw-r--r-- | configure.ac | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/configure.ac b/configure.ac index 10c8d06..ba8b188 100644 --- a/configure.ac +++ b/configure.ac @@ -51,14 +51,9 @@ AC_ARG_ENABLE([virtual-pnor], ) AS_IF([test "x$enable_virtual_pnor" == "xyes"], [ - PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],,\ - AC_MSG_ERROR(["Requires sdbusplus package."])) - - PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],,\ - AC_MSG_ERROR(["Requires phosphor-logging package."])) - - AX_PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [],[phosphor-dbus-interfaces],\ - [], [AC_MSG_ERROR(["phosphor-dbus-interfaces required and not found."])]) + PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus]) + PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging]) + AX_PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [],[phosphor-dbus-interfaces]) AM_CONDITIONAL(VIRTUAL_PNOR_ENABLED, true) AX_APPEND_COMPILE_FLAGS([-DVIRTUAL_PNOR_ENABLED], [CXXFLAGS]) |