diff options
author | Joseph Reynolds <jrey@us.ibm.com> | 2018-05-04 10:11:00 -0500 |
---|---|---|
committer | Joseph Reynolds <jrey@us.ibm.com> | 2018-06-22 13:54:45 +0000 |
commit | 8f6f7fc3ccea4a1a32d17f4c335cbe7040fde068 (patch) | |
tree | 43cb86cca9362f47b7cdbaed7cae0b60d286d3eb /test | |
parent | 4a029f2f401a6738c6daa31ad3098eb7f0915c7c (diff) | |
download | phosphor-logging-8f6f7fc3ccea4a1a32d17f4c335cbe7040fde068.tar.gz phosphor-logging-8f6f7fc3ccea4a1a32d17f4c335cbe7040fde068.zip |
static_assert typeof log message entries
Please wait to commit this review until all of the code that
causes static_assert failures is committed.
Resolves openbmc/openbmc#2905
Tested: static_assert only
phosphor-logging now static_asserts that each item to be converted
by the printf-like function has integral, enum, floating_point, or
pointer type and each format argument has a type that decays to
a char * type.
Specifically, std::string fails the assertion because
its address would be logged and not the string buffer. You
probably want your strings to use s.c_str().
Note that we considered automatically applying c_str() to string
objects, but the underlying entry function is constexpr which
makes that impossible.
Change-Id: I88f6c626d58254eaad9b1a44e6a9c693d2fc6cd9
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions