diff options
author | Matt Spinler <spinler@us.ibm.com> | 2019-10-11 10:39:30 -0500 |
---|---|---|
committer | Matt Spinler <spinler@us.ibm.com> | 2019-10-22 09:10:37 -0500 |
commit | 42828bd922d6e067089770112de5ec22d2df8ab1 (patch) | |
tree | 61a552dbfaa53f7eb1e3104a8a8d73f60548e15f /test/openpower-pels/private_header_test.cpp | |
parent | 31eed996da81cf6e35e7ddd035aa8088be230218 (diff) | |
download | phosphor-logging-42828bd922d6e067089770112de5ec22d2df8ab1.tar.gz phosphor-logging-42828bd922d6e067089770112de5ec22d2df8ab1.zip |
PEL: Refactor the test data factory
This commit has no functional changes, it just does some things
to make the PEL data creator for testcases, pelDataFactory(), be
more manageable:
- Change to return a plain vector instead of a unique_ptr<vector>.
- Keeps the data for each section in separate vectors and then
either returns those as-is or combines them into a PEL.
- Change the TestPelType enum to TestPELType to match the style guide.
- Have pelDataFactory provide the SRC section instead of srcDataFactory.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4770aa6a8169e89b6b8f685a9994d845c9e93cfe
Diffstat (limited to 'test/openpower-pels/private_header_test.cpp')
-rw-r--r-- | test/openpower-pels/private_header_test.cpp | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/test/openpower-pels/private_header_test.cpp b/test/openpower-pels/private_header_test.cpp index ebb515c..07746b3 100644 --- a/test/openpower-pels/private_header_test.cpp +++ b/test/openpower-pels/private_header_test.cpp @@ -16,9 +16,9 @@ TEST_F(PrivateHeaderTest, SizeTest) TEST_F(PrivateHeaderTest, UnflattenFlattenTest) { - auto data = pelDataFactory(TestPelType::privateHeaderSimple); + auto data = pelDataFactory(TestPELType::privateHeaderSection); - Stream stream(*data); + Stream stream(data); PrivateHeader ph(stream); EXPECT_EQ(ph.valid(), true); @@ -65,7 +65,7 @@ TEST_F(PrivateHeaderTest, UnflattenFlattenTest) Stream newStream(newData); ph.flatten(newStream); - EXPECT_EQ(*data, newData); + EXPECT_EQ(data, newData); // Change a field, then flatten and unflatten again ph.creatorID() = 0x55; @@ -73,7 +73,7 @@ TEST_F(PrivateHeaderTest, UnflattenFlattenTest) newStream.offset(0); newData.clear(); ph.flatten(newStream); - EXPECT_NE(*data, newData); + EXPECT_NE(data, newData); newStream.offset(0); PrivateHeader newPH(newStream); @@ -84,9 +84,9 @@ TEST_F(PrivateHeaderTest, UnflattenFlattenTest) TEST_F(PrivateHeaderTest, ShortDataTest) { - auto data = pelDataFactory(TestPelType::privateHeaderSimple); - data->resize(PrivateHeader::flattenedSize() - 1); - Stream stream(*data); + auto data = pelDataFactory(TestPELType::privateHeaderSection); + data.resize(PrivateHeader::flattenedSize() - 1); + Stream stream(data); PrivateHeader ph(stream); @@ -95,10 +95,10 @@ TEST_F(PrivateHeaderTest, ShortDataTest) TEST_F(PrivateHeaderTest, CorruptDataTest1) { - auto data = pelDataFactory(TestPelType::privateHeaderSimple); - Stream stream(*data); + auto data = pelDataFactory(TestPELType::privateHeaderSection); + Stream stream(data); - data->at(0) = 0; // corrupt the section ID + data.at(0) = 0; // corrupt the section ID PrivateHeader ph(stream); @@ -107,10 +107,10 @@ TEST_F(PrivateHeaderTest, CorruptDataTest1) TEST_F(PrivateHeaderTest, CorruptDataTest2) { - auto data = pelDataFactory(TestPelType::privateHeaderSimple); - Stream stream(*data); + auto data = pelDataFactory(TestPELType::privateHeaderSection); + Stream stream(data); - data->at(4) = 0x22; // corrupt the version + data.at(4) = 0x22; // corrupt the version PrivateHeader ph(stream); @@ -119,10 +119,10 @@ TEST_F(PrivateHeaderTest, CorruptDataTest2) TEST_F(PrivateHeaderTest, CorruptDataTest3) { - auto data = pelDataFactory(TestPelType::privateHeaderSimple); - Stream stream(*data); + auto data = pelDataFactory(TestPELType::privateHeaderSection); + Stream stream(data); - data->at(27) = 1; // corrupt the section count + data.at(27) = 1; // corrupt the section count PrivateHeader ph(stream); |