summaryrefslogtreecommitdiffstats
path: root/extensions/openpower-pels/registry
diff options
context:
space:
mode:
authorMatt Spinler <spinler@us.ibm.com>2019-10-30 15:50:37 -0500
committerMatt Spinler <spinler@us.ibm.com>2019-11-12 16:17:18 +0000
commit3fb208e3ded3a41c8c65e7a3880e4c31bd2648f9 (patch)
tree276769397304f262d87dd00541e90fa9654e6885 /extensions/openpower-pels/registry
parent1ea78801ce35583c988a45555160adcdac280a83 (diff)
downloadphosphor-logging-3fb208e3ded3a41c8c65e7a3880e4c31bd2648f9.tar.gz
phosphor-logging-3fb208e3ded3a41c8c65e7a3880e4c31bd2648f9.zip
PEL: Registry: Make "Action Flags" optional
The Action Flags bits in the PEL need to be in agreement with other PEL fields, such as if the severity is informational then the 'report' flag cannot be on. In fact, for most logs all of these flags can be deduced from the other PEL fields. So, to avoid the case of the action flags in the registry not matching the other PEL fields, make them optional and the BMC code will set them appropriately. And when they are specified, the BMC code will still run through the same code to ensure everything is in agreement. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I5bea83d01846d7a2d3307666e6d0758a99229e3f
Diffstat (limited to 'extensions/openpower-pels/registry')
-rw-r--r--extensions/openpower-pels/registry/README.md10
-rw-r--r--extensions/openpower-pels/registry/schema/schema.json3
2 files changed, 10 insertions, 3 deletions
diff --git a/extensions/openpower-pels/registry/README.md b/extensions/openpower-pels/registry/README.md
index dae6bbc..a0e6f49 100644
--- a/extensions/openpower-pels/registry/README.md
+++ b/extensions/openpower-pels/registry/README.md
@@ -80,7 +80,8 @@ the event scope, as defined by the PEL spec. It is optional and defaults to
### Event Type
This field is part of the PEL User Header section, and is used to specify
the event type, as defined by the PEL spec. It is optional and defaults to
-"not applicable".
+"not applicable" for non-informational logs, and "misc_information_only" for
+informational ones.
```
"EventType": "na"
@@ -90,6 +91,13 @@ the event type, as defined by the PEL spec. It is optional and defaults to
This field is part of the PEL User Header section, and is used to specify the
PEL action flags, as defined by the PEL spec. It is an array of enumerations.
+The action flags can usually be deduced from other PEL fields, such as the
+severity or if there are any callouts. As such, this is an optional field and
+if not supplied the code will fill them in based on those fields.
+
+In fact, even if supplied here, the code may still modify them to ensure they
+are correct.
+
```
"ActionFlags": ["service_action", "report", "call_home"]
```
diff --git a/extensions/openpower-pels/registry/schema/schema.json b/extensions/openpower-pels/registry/schema/schema.json
index 3e94cd4..10fdff9 100644
--- a/extensions/openpower-pels/registry/schema/schema.json
+++ b/extensions/openpower-pels/registry/schema/schema.json
@@ -52,8 +52,7 @@
"ComponentID": {"$ref": "#/definitions/componentID" }
},
- "required": ["Name", "SRC", "Subsystem", "Documentation",
- "ActionFlags"],
+ "required": ["Name", "SRC", "Subsystem", "Documentation"],
"additionalProperties": false
}
},
OpenPOWER on IntegriCloud