summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Spinler <spinler@us.ibm.com>2019-09-13 13:19:44 -0500
committerMatt Spinler <spinler@us.ibm.com>2019-09-18 14:47:16 +0000
commit14dc04117c7dd88317d3b2ae851f6cb202221b69 (patch)
treeed7e2674edc8d9a0209c7d6246ec57021f696816
parent5eb6a2acc0e8979c004a257f2e53fb4dff5f1566 (diff)
downloadphosphor-logging-14dc04117c7dd88317d3b2ae851f6cb202221b69.tar.gz
phosphor-logging-14dc04117c7dd88317d3b2ae851f6cb202221b69.zip
PEL: Remove extraneous return statements
UserHeader::validate() had some extra return statements that aren't needed. It is desired for the function to run all the way through even on a validation failure. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I9b99970179cd7c84a0201b7d67e39b0bee209beb
-rw-r--r--extensions/openpower-pels/user_header.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/extensions/openpower-pels/user_header.cpp b/extensions/openpower-pels/user_header.cpp
index 117ade1..917d578 100644
--- a/extensions/openpower-pels/user_header.cpp
+++ b/extensions/openpower-pels/user_header.cpp
@@ -46,7 +46,6 @@ void UserHeader::validate()
log<level::ERR>("Invalid user header section ID",
entry("ID=0x%X", header().id));
failed = true;
- return;
}
if (header().version != userHeaderVersion)
@@ -54,7 +53,6 @@ void UserHeader::validate()
log<level::ERR>("Invalid user header version",
entry("VERSION=0x%X", header().version));
failed = true;
- return;
}
_valid = (failed) ? false : true;
OpenPOWER on IntegriCloud