diff options
author | Andrew Jeffery <andrew@aj.id.au> | 2019-03-18 17:20:37 +1030 |
---|---|---|
committer | Andrew Jeffery <andrew@aj.id.au> | 2019-04-08 13:48:50 +0930 |
commit | 5b1417bd21d1e9c00b25bb6db700aec442af746d (patch) | |
tree | de53af30b71dbde0bb9b72cba4dc42c2842491b6 /physical.hpp | |
parent | 2332e91ff6b0758026ce68f049a74cda6e13b702 (diff) | |
download | phosphor-led-sysfs-master.tar.gz phosphor-led-sysfs-master.zip |
The kernel says the following about the LED sysfs interface:
> LED handling under Linux
> ========================
>
> In its simplest form, the LED class just allows control of LEDs from
> userspace. LEDs appear in /sys/class/leds/. The maximum brightness of the
> LED is defined in max_brightness file. The brightness file will set the brightness
> of the LED (taking a value 0-max_brightness). Most LEDs don't have hardware
> brightness support so will just be turned on for non-zero brightness settings.
The existing code assumed that max_brightness always held a value of
255 and defined a constant for it. Instead, use a class variable to
cache the max brightness for the associated LED.
Change-Id: I2d8f46de0cddac5f9d8ff5444449518bb4056130
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Diffstat (limited to 'physical.hpp')
-rw-r--r-- | physical.hpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/physical.hpp b/physical.hpp index e588de2..67a900b 100644 --- a/physical.hpp +++ b/physical.hpp @@ -12,10 +12,7 @@ namespace phosphor { namespace led { -/** @brief Assert LED by writing 255 */ -constexpr unsigned long ASSERT = 255; - -/** @brief De-assert by writing "0" */ +/** @brief De-assert value */ constexpr unsigned long DEASSERT = 0; /** @class Physical @@ -69,6 +66,9 @@ class Physical : public sdbusplus::server::object::object< */ SysfsLed& led; + /** @brief The value that will assert the LED */ + unsigned long assert; + /** @brief The period that the LED will operate on, in milliseconds * Will be removed when periodicity is put into interface */ |