1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
|
#include "ipmi.hpp"
#include "manager_mock.hpp"
#include <cstring>
#include <gtest/gtest.h>
namespace blobs
{
using ::testing::_;
using ::testing::ElementsAreArray;
using ::testing::Return;
// ipmid.hpp isn't installed where we can grab it and this value is per BMC
// SoC.
#define MAX_IPMI_BUFFER 64
TEST(BlobCommitTest, InvalidCommitDataLengthReturnsFailure)
{
// The commit command supports an optional commit blob. This test verifies
// we sanity check the length of that blob.
ManagerMock mgr;
size_t dataLen;
uint8_t request[MAX_IPMI_BUFFER] = {0};
uint8_t reply[MAX_IPMI_BUFFER] = {0};
auto req = reinterpret_cast<struct BmcBlobCommitTx*>(request);
req->cmd = BlobOEMCommands::bmcBlobCommit;
req->crc = 0;
req->sessionId = 0x54;
req->commitDataLen =
1; // It's one byte, but that's more than the packet size.
dataLen = sizeof(struct BmcBlobCommitTx);
EXPECT_EQ(IPMI_CC_INVALID, commitBlob(&mgr, request, reply, &dataLen));
}
TEST(BlobCommitTest, ValidCommitNoDataHandlerRejectsReturnsFailure)
{
// The commit packet is valid and the manager's commit call returns failure.
ManagerMock mgr;
size_t dataLen;
uint8_t request[MAX_IPMI_BUFFER] = {0};
uint8_t reply[MAX_IPMI_BUFFER] = {0};
auto req = reinterpret_cast<struct BmcBlobCommitTx*>(request);
req->cmd = BlobOEMCommands::bmcBlobCommit;
req->crc = 0;
req->sessionId = 0x54;
req->commitDataLen = 0;
dataLen = sizeof(struct BmcBlobCommitTx);
EXPECT_CALL(mgr, commit(req->sessionId, _)).WillOnce(Return(false));
EXPECT_EQ(IPMI_CC_INVALID, commitBlob(&mgr, request, reply, &dataLen));
}
TEST(BlobCommitTest, ValidCommitNoDataHandlerAcceptsReturnsSuccess)
{
// Commit called with no data and everything returns success.
ManagerMock mgr;
size_t dataLen;
uint8_t request[MAX_IPMI_BUFFER] = {0};
uint8_t reply[MAX_IPMI_BUFFER] = {0};
auto req = reinterpret_cast<struct BmcBlobCommitTx*>(request);
req->cmd = BlobOEMCommands::bmcBlobCommit;
req->crc = 0;
req->sessionId = 0x54;
req->commitDataLen = 0;
dataLen = sizeof(struct BmcBlobCommitTx);
EXPECT_CALL(mgr, commit(req->sessionId, _)).WillOnce(Return(true));
EXPECT_EQ(IPMI_CC_OK, commitBlob(&mgr, request, reply, &dataLen));
}
TEST(BlobCommitTest, ValidCommitWithDataHandlerAcceptsReturnsSuccess)
{
// Commit called with extra data and everything returns success.
ManagerMock mgr;
size_t dataLen;
uint8_t request[MAX_IPMI_BUFFER] = {0};
uint8_t reply[MAX_IPMI_BUFFER] = {0};
auto req = reinterpret_cast<struct BmcBlobCommitTx*>(request);
uint8_t expectedBlob[4] = {0x25, 0x33, 0x45, 0x67};
req->cmd = BlobOEMCommands::bmcBlobCommit;
req->crc = 0;
req->sessionId = 0x54;
req->commitDataLen = sizeof(expectedBlob);
std::memcpy(req->commitData, &expectedBlob[0], sizeof(expectedBlob));
dataLen = sizeof(struct BmcBlobCommitTx) + sizeof(expectedBlob);
EXPECT_CALL(mgr,
commit(req->sessionId,
ElementsAreArray(expectedBlob, sizeof(expectedBlob))))
.WillOnce(Return(true));
EXPECT_EQ(IPMI_CC_OK, commitBlob(&mgr, request, reply, &dataLen));
}
} // namespace blobs
|