diff options
| author | Patrick Venture <venture@google.com> | 2018-11-12 10:46:30 -0800 |
|---|---|---|
| committer | Patrick Venture <venture@google.com> | 2018-11-13 11:07:44 -0800 |
| commit | 4125880028cc4a825f710b9e1b09986aacd4e1bb (patch) | |
| tree | b6d8defec27f0aefd5ac9b82356a9dd931a95ec4 /test/ipmi_commit_unittest.cpp | |
| parent | 45e428a2b22f5ba134fa07ede6be1f99d12a6c2c (diff) | |
| download | phosphor-ipmi-blobs-4125880028cc4a825f710b9e1b09986aacd4e1bb.tar.gz phosphor-ipmi-blobs-4125880028cc4a825f710b9e1b09986aacd4e1bb.zip | |
process: add IPMI error return mechanism and update errors
The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invalid command
error.
Update all IPMI handler pieces to return more specific errors.
Change-Id: I8d21e92015d84cc0880e3b83991aed7288e19eab
Signed-off-by: Patrick Venture <venture@google.com>
Diffstat (limited to 'test/ipmi_commit_unittest.cpp')
| -rw-r--r-- | test/ipmi_commit_unittest.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/test/ipmi_commit_unittest.cpp b/test/ipmi_commit_unittest.cpp index 34ff10d..30f78bf 100644 --- a/test/ipmi_commit_unittest.cpp +++ b/test/ipmi_commit_unittest.cpp @@ -35,7 +35,8 @@ TEST(BlobCommitTest, InvalidCommitDataLengthReturnsFailure) dataLen = sizeof(struct BmcBlobCommitTx); - EXPECT_EQ(IPMI_CC_INVALID, commitBlob(&mgr, request, reply, &dataLen)); + EXPECT_EQ(IPMI_CC_REQ_DATA_LEN_INVALID, + commitBlob(&mgr, request, reply, &dataLen)); } TEST(BlobCommitTest, ValidCommitNoDataHandlerRejectsReturnsFailure) @@ -57,7 +58,8 @@ TEST(BlobCommitTest, ValidCommitNoDataHandlerRejectsReturnsFailure) EXPECT_CALL(mgr, commit(req->sessionId, _)).WillOnce(Return(false)); - EXPECT_EQ(IPMI_CC_INVALID, commitBlob(&mgr, request, reply, &dataLen)); + EXPECT_EQ(IPMI_CC_UNSPECIFIED_ERROR, + commitBlob(&mgr, request, reply, &dataLen)); } TEST(BlobCommitTest, ValidCommitNoDataHandlerAcceptsReturnsSuccess) |
