| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
The behavior of std::filesystem::path::append changed on its journey
from experimental:: to std::
Add a testcase and adapt to the behavior change.
Fixes: e6b21c74581c30ea635aabbbc08d0a56f8e27063
Change-Id: I4bdb43ea9b85933ec12ae0f4b609ec3a33d77d01
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Add a basic compile time test that ensures manager.hpp can build on
its own.
Change-Id: Id10cdd8135fd4a41ebf2a76bc1e0da2d1916c6fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of the templates in manager.hpp are _almost_ testable. Enable
testing by porting to a new header - interface_ops.hpp - to be activated
later.
Enhancements include:
Dropped 'PropertiesVariant' wrapper template for reduced comprehensional
complexity.
More intuitive HasProperties implementation. HasProperties is a type
traits template that simply checks for the presence of a nested
PropertiesVariant typename. These are provided by sdbusplus generated
server bindings for dbus interfaces that have properties.
Standalone templates for make, assign, serialize and deserialize
interface. There was no good reason to couple these, and the
resulting types and method names are more intuitive.
Templated serialize/deserialize operations so the dependency on
cereal can be abstracted away.
Change-Id: Ia449628eeaa9732bbbc51b0609bd449f43ebcb7c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Add a basic compile time test that ensures serialize.hpp can build on
its own.
Change-Id: Ib83e9fa73fd44c00884299b48b896f1fe53752c7
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Ensure utils.hpp can build on its own, and add some unit tests.
Change-Id: Ia147b699105ff4497d9226630ef19e57d91de3c3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Add a basic compile time test that ensures types.hpp can build on its
own.
Change-Id: Idbf8a68feb1bf30b4fb573d254edf3a2f0a6f0cc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Add the test driver so we can run unit tests with the check target.
Drop GTEST_CPPFLAGS - gtest has proper pkg-config support now.
Default not-found messages are sufficient - use those.
Change-Id: I887f6bc46a029b6b23254da7508745952f865869
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
This change makes it possible to use std::variant as a drop in
replacement for mapbox::variant.
Change-Id: Ia729c3a7832eec4dd6cddadba9bc160b6ba9ad90
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
clang-format-6.0 introduced new changes, also then updates to
.clang-format introduce more new changes.
Change-Id: Iec9f84e3a7a5bf254d66eee46cdc9b3070e06687
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Fix up problems and enable clang-format during CI builds.
Change-Id: Ia5c88281f7090c0aa09ba586d968f1fcd8aba4f1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
React to a GCC7.2 behavioral differences where
assert(sdbusplus::message::message) no longer compiles.
sdbusplus::message::message implements operator bool which
prior to GCC7.2 was emitted implicitly. Add an explicit
cast to bool where required.
Tested: Built repository using GCC 7.2
Change-Id: I49fb05d616ba1f790ef68365983b1f85aa91e46a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Subsequent commits will introduce serialization of inventory properties.
Generate the save()/load() functions required by Cereal.
Change-Id: I2ce16d205cad9684711c49c32ddae9f69cd8632d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
| |
sdbusplus::server::match::match moved to the sdbusplus::bus namespace.
Change-Id: Ib1599f7efbf63570685a7029811f2eeb69ef6ace
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
| |
Define CXXFLAGS rather than CFLAGS.
Add libraries via LIBADD rather than LDFLAGS. This allows
--as-needed to drop unnecessary libs if present.
Don't bother with PIC objects for convenience library.
Change-Id: I8e09a79a69b35be702811b594fed506332a23c43
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Whitespace changes only.
Change-Id: I0ff90593850c4f79b56587a315caa0ca51df8936
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
This ends up being more portable.
Change-Id: I9e4e0414329878316a110a5234aeea4677b877e8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Make use of new sdbusplus support for passing a map
of properties and their values to the interface
constructor.
Change-Id: Ib0dd406fd80c89acb723e3a376af26ba57b53d27
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Link with libphosphor_dbus.
Update the manager implementation to match the new server binding
in libphosphor_dbus (bool types for notify and notify
signature change).
Change-Id: I033d224965caf737591e363b3e2fd666605bff13
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run pimgen twice, once for the application with the real YAML
and once for the testcase with the example YAML so that the
testcase can run and build sucessfully when an alternate YAML
tree is provided.
Move extra interface rule generation from pimgen to a makefile
generating script.
Change-Id: Ib0c01bd2207007b815019232a466fa16889f2005
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Allow clients to specify filters and actions that trigger
on application startup.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ib36c5bab778d7c87906dd3f61a3a6e033c7ccde1
|
|
|
|
|
| |
Change-Id: I999a5e506a236eac8ca0944b0e2b003c57612e54
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Currently the testcase and the application both define their
own Object type. Move to a common header.
Change-Id: I05dba67dca7855f522be299fcfd361913ed73fbc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The existing property match filter tests a property
in the PropertiesChanged signal payload.
Add a match filter that tests any arbitrary property on
any object.
Change-Id: I1c238c03a3ccbf45f7b338693a4342fbd4f670c2
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
| |
Prior to this change this template will not build with types
other than strings.
Add an example that tests this.
Change-Id: I71e5c4136e7e4fd52fea3e8e027e42634011d630
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Put the trigger object in its own thread rather than
the inventory manager thread. This allows the thread
under test to make calls to it.
Change-Id: I181d2d46a10e4193653df61205ac3380a1d4db2e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Comparing strings to object paths directly isn't supported
at the moment.
Change-Id: I98083cf563fe8dde74e7f058720a0481bbe7c2e6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Re-run sdbus++ and react to the sdbusplus interface namespace
move and a real object path type.
Change-Id: Id6241b55cd3f2d4c3b85e5545e4ac6e5dd439e34
|
|
|
|
|
| |
Change-Id: I7ea63f3b78e62fa40247806ceca7b84b7e36f875
Signed-off-by: Brad Bishop <<bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I7f2927deee84701f3ed7bec86ec97171a5daabb8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: Iec4802e9837465a7deb1fd7fd57a2068cc18c50d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ifade8963ebc8d18dbdca46ece16800cf8ea8a6ad
|
|
|
|
|
|
|
|
|
|
| |
Validate that:
-Dbus signal callbacks are established.
-The propertyChangedTo filter works correctly.
-The destroyObject action works correctly.
Change-Id: I0981fed76aa26ff275a401ae81fd230833dfc4cc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Validate signal content rather than doing explicit property
lookups. This avoids race conditions and additionally validates
that a signal is sent with the correct values.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Iaf13b1dfd68eeaf8ab7e8dc3bf045f824c3c803a
|
|
|
|
|
| |
Change-Id: Id6bf8564ea4b99dbd80d0326359e2c3ad8e3ab7d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Eventually server.hpp will come from an external shared
library. Until then, iquote it while it lives in-tree.
Change-Id: If0f7da8e2c951443fea0d623ad03a7c54a5a5ee9
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I82d781923fc84e79262a5ffd2ff64488e777a076
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
The existing testcase isn't a unit test.
Change-Id: I2325d7e641736c5290c7e95d37ab43313695ae58
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Automatically populate the association of interface with an
appropriate sdbusplus server side interface binding.
Change-Id: Ie46d91cf2e6726b033789be6228c10ca14a76220
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Add an autoconf opttion that includes the example
bindings, for use in standalone/testing environments.
Change-Id: Id44f02a9bc7adcc8b36c09f0867ee1a663d7e25c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I5c1e250a0cfd3aecf84709b90bc01a97e5673eaf
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Eventually any DBus interfaces in phosphor-dbus-interfaces will
have bindings generated and available in a shared library.
Add the generated Manager interface directly to the repository until
that happens.
Change-Id: I9e1ac3266ca6467bbddbbd12ed2d2de6c079765b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Add a signal match filter for properties changing to a specific
value.
Change-Id: I10f20ba03ae7c629d2c338c7975e0d32d9008e01
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Add stubbed Notify implementation and register for generated
signal callbacks.
Add a unit test; which, at this point does little more than
verify we don't coredump on startup.
Change-Id: I0cda71935947c0d082612a5c52e2b7eba98516ab
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|