diff options
| author | Patrick Venture <venture@google.com> | 2019-02-13 07:40:21 -0800 |
|---|---|---|
| committer | Patrick Venture <venture@google.com> | 2019-02-13 07:40:21 -0800 |
| commit | 09d9c23699f625479c85724c34421c52be7b17e4 (patch) | |
| tree | c1bc59b74d37160f6c7d519cc4581d0d6440c0a9 | |
| parent | cd40c8815a9533cb72d97e1d316e91650f14b024 (diff) | |
| download | phosphor-hwmon-09d9c23699f625479c85724c34421c52be7b17e4.tar.gz phosphor-hwmon-09d9c23699f625479c85724c34421c52be7b17e4.zip | |
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: Iad7753b8e6a80307ad57a9a6dd2d442ec7fe0e67
Signed-off-by: Patrick Venture <venture@google.com>
| -rw-r--r-- | configure.ac | 35 |
1 files changed, 5 insertions, 30 deletions
diff --git a/configure.ac b/configure.ac index 6bfb254..0c8fc09 100644 --- a/configure.ac +++ b/configure.ac @@ -13,36 +13,11 @@ AC_PROG_INSTALL AC_PROG_MAKE_SET # Checks for libraries. -PKG_CHECK_MODULES( - [SDBUSPLUS], - [sdbusplus], - [], - [AC_MSG_ERROR(["sdbusplus required and not found."])] -) -PKG_CHECK_MODULES( - [SDEVENTPLUS], - [sdeventplus], - [], - [AC_MSG_ERROR(["sdeventplus required and not found."])] -) -PKG_CHECK_MODULES( - [PHOSPHOR_DBUS_INTERFACES], - [phosphor-dbus-interfaces], - [], - [AC_MSG_ERROR(["phosphor-dbus-interfaces required and not found."])] -) -PKG_CHECK_MODULES( - [PHOSPHOR_LOGGING], - [phosphor-logging], - [], - [AC_MSG_ERROR(["phosphor-logging required and not found."])] -) -PKG_CHECK_MODULES( - [GPIOPLUS], - [gpioplus], - [], - [AC_MSG_ERROR([Could not find gpioplus...openbmc/gpioplus package required])] -) +PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus]) +PKG_CHECK_MODULES([SDEVENTPLUS], [sdeventplus]) +PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces]) +PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging]) +PKG_CHECK_MODULES([GPIOPLUS], [gpioplus]) AX_PTHREAD([], [AC_MSG_ERROR(["pthread required and not found"])]) # Checks for typedefs, structures, and compiler characteristics. |
