| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
Until now, IPMI chassis command handler was utilising services from
chassis_control script and this patch makes a transition to use the
services from the latest State Manager daemon.
Fixes openbmc/openbmc#1238
Change-Id: Ic075971bbda44829a3ebe9c0c1de3053a8e97cfa
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Fixes openbmc/openbmc#1159
Change-Id: Ieaddee28ec53d8c343eeee472de231aa09cbcd43
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Fixes openbmc/openbmc#1236
Change-Id: I6a3478c11e9111145284ca028034355ebe085b5a
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
| |
Change-Id: If55367f35cfcf35f0dff8da2d1e15865b702a5b2
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Phase2: Changing the phosphor-logging header files import from
base dir to files under phosphor-logging folder. Once all projects
import from the new dir, the files in the base dir will be deleted.
Change-Id: If45e9d29056c66e2c4b03a6ca20580f30b69741f
Signed-off-by: Saqib Khan <khansa@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Ib9bb50332c4203ccbbe72e3e5b9e641a51bdacbb
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
The current add_sel dbus calls are failing, openbmc/openbmc#1111
Remove them as they are deprecated as the function already creates
an elog error entry using the new logging interface.
Change-Id: I3616496420b539bbb7ea5b3fe0c3841d655df238
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Log the SEL data to the journal and call the commit
interface to write the error log with the data.
Change-Id: Ifcb842e37f2fdb14f80ab24651d565da05da47bf
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
|
|
|
|
|
| |
The provider libraries are copied into /usr/lib/ipmid-providers
Change-Id: I8a8ee34b77483ea8c4f47f3cfa5fa4c505c7a29b
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I63c18de7704db826efdbb8a44218720f63b3c4c2
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Fix compilation errors found with later gcc version during integration
unit tests.
Resolves openbmc/phosphor-host-ipmid#101
Change-Id: I35c5433f03521a877fd09748b8262d6172d21535
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I07f160c6ea83dc91f46e21f263c4cf994aff081d
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
There are IPMI commands like Read Event Message Buffer, Set BMC Global
Enables and Get Message Flags which is to be executed from host
interface only. So creating a separate library for these commands which
would be used only by phosphor-host-ipmid.
Change-Id: I14cb4019b9ab19c84e463e5a7820010f57f1c5eb
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Removed unnecessary ipmiwhitelist entry so not to be
mistakenly added to SOURCES.
Change-Id: I971a80dfb9ba942c7e8048d706cd9b59ac224c11
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Per the IPMI 2.0 spec, the input and output buffer size
must be maximum buffer size minus one byte to allocate
space for the length byte.
Change-Id: Ie1768b9c6844275f7897fbf8056ce2a19b1c11c3
Fixes: openbmc/openbmc#847
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Ipmid will cache single setting to memory by Set Lan cmd
* Add Set Channel Access cmd to ipmid
* Set Channel Access cmd is used to apply the previous cached settings
TODO: parse the request data of Set Channel Access cmd if needed.
Resolves openbmc/openbmc#444
Change-Id: Ia7ac57a551731920ffe69dad5c69c995521fed02
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed in design meeting, before the whole ipmi stack is
implemented, we don't plan to support "self test". So just respond
with self test function not implemented in this controller.
Resolves openbmc/openbmc#436
Change-Id: Icd72e07674ce857f98ac036df2b7d6f6b93f1914
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
|
|
|
|
| |
GET_SEL_TIME and SET_SEL_TIME command handlers are using gettimeofday and
settimeofday respectively. This patch will change the mechanism to use APIs that
are provided by org.openbmc.TimeManager daemon istead of POSIX calls.
Change-Id: I4890f4a2c27131d902e7417db023eb4cdd7d8626
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/phosphor-host-ipmid#100
Change-Id: I6003829eaee5330ff62b239166be428b4ff43991
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
The test directory needs -I$(top_srcdir) in order to find the
header files provided by the project itself. When doing an in-tree
build, this is done automatically by automake due to 'config.h'
being generated in the root.
Change-Id: I5e59715657684a8019e9c48c835b29eb326f01a8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Factor response to explicitly commented fields
* Add GetChassisStatus command to whilelist
Note: some fields need furture work.
Resolves openbmc/openbmc#439
Change-Id: I7a8d6bfe384f2621c157db379680921db4756fcc
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
|
|
|
| |
Use the sdbus client binding for this to protect
from changes within the binding itself.
Change-Id: I152b254bbf21360a5096d9e0f48bd99fc29d737b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
| |
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I700c5847685b4432c1da42ec470860f1785b9abf
|
|
|
|
|
| |
Change-Id: I599d8297b4d2fd45831443685ea5b7d53f1515b6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement by calling dbus method for coldReset
* Optimize warmReset/coldReset code
* Be implemented with related changes in skeleton repository
Resolves openbmc/openbmc#437
Change-Id: Ia33805c73b5d345419918c467ef7b9cf6fbb246d
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement response to separately commented fields.
* Add to the whitelist.
Note: some hardcoded fields need future work.
Resolve openbmc/openbmc#438.
Change-Id: Ica9a55a14987ddc6b9984c7d3dcb143416ee7e37
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
|
|
| |
Enable use of GoogleTest and created a sample unit test case.
Change-Id: Ie370745a32777d4ed81ee24145364029c8e7bf02
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Ic40d1a14d50acbfe74046e4d763d441db33a286d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: If186487d7118010c30e39ab96f13558ba5d7f6fb
Signed-off-by: Tom <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
The sensor related code is moved to sensorhandler.c. These changes
were part of the ipmi daemon code and would have to replicated in
RMCP daemon. The refactoring would get away with those changes.
Change-Id: Ib9e1a1929282221e6f259e4a54502eea82f42939
Signed-off-by: Tom <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Corrected resulting compiler errors from correctly adding -Wall &
-Werror within configure.ac.
Change-Id: Ia7aaafa83103322ad4b50171d62144624dd71e42
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Ieebaa759f59c6c2a020eb18120d4b48b7dc4a4f9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
| |
A number of callbacks are registered for 'WILDCARD' types, which
currently do nothing except respond with CC_OK(00h). Change complete
codes to CC_INVALID(C1h).
Resolves openbmc/openbmc#469.
Change-Id: I91ea5ee1a23284a4159ff1c1867342e89c6fa444
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
| |
Change-Id: If4b97e65f63c3abbf23140dd97b9febe00b3be0d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
| |
Change-Id: Ia1ed05a533736105909717b86f16274b30d36401
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
| |
Change-Id: I1b4d00211913d1be61f33dfb02227ffc8f859584
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
| |
Change-Id: Id01b9ad969f96b0f79623ad9cf2a06f6714a07b1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
| |
Change-Id: I55db0cf7f6041890564f557c98286c8b4bde80cb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
| |
Replaced the use of manual Makefile(s) with the use of autotools to
automatically verify and generate the necessary build files. Follow the
steps outlined within the README file to build the package.
Change-Id: Ia3e1e1be7b18fb90382fd56f555866120ae5ece9
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to implement the network settings override functionality.
This is an OEM boot parameter selector, using parameter ID 0x61.
The first byte of the parameter data is the same as parameter ID 5 (ie,
the valid flag in the top bit). Persistency doesn't matter here, as
petitboot will not clear out this setting.
The rest of the parameter data is a host network settings description.
For other BMC firmware, the BMC just treats this as opaque (the BMC will
just return the same data (including that data1 byte), in response to a
Get System Boot Option). For OpenBMC, we may want the BMC to know how to
construct that data; the spec for that is at:
http://ozlabs.org/~sam/ipmi-network-format
Closes openbmc/openbmc#267
Change-Id: I2af8776718deda97acf90d10504783085ccf7323
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the openbmc code, the dbus service name is hardcoded.
The ObjectMapper provides a way to find out the service name by
issuing a GetObject method call to the ObjectMapper.
That functionality is implemented in mapper.c
The output of the call to the mapper is a service name.
Resolves openbmc/openbmc#319.
Change-Id: I724a31ede6bdf3ae4b361e730857b1f2696a8966
Signed-off-by: Sergey Solomin <sergey.solomin@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I9480ef48c410708cf2b5fb97c4ac93ef486c6cd2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Refactor response from constant array to explicitly commented fields.
* Update comments for fields.
* Refer to FSP implementation where appropriate.
Note: Some of the fields present here should be filled in from MRW or
runtime settings in the future.
Resolves openbmc/openbmc#435.
Change-Id: I733274e237cf28d5048c44d527a8fd67a0392168
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
|
|
|
|
|
| |
Change-Id: I495186b4afd58ec1e5d9d5c6472394f96541d17d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Whitelisting of IPMI commands is done to ensure that in restricted
mode only whitelisted commands are executed. Commands that are not
whitelisted is restricted and insufficient privilege is returned as the
completion code.
When the server is deployed it would be set to restricted mode. In this
scenario certain IPMI commands need to be restricted which would not be
added to the whitelist.
Change-Id: I90b8124e34263c4ffc5bcf06a28a7e88231aaf40
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
This is a reaction to a managers.System API update. The
update removes the bus name field from the 'GetObject'
method responses.
Change-Id: I51fb1d1bad20317a429e5b06712475929b6fb4fb
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux libraries, including the ipmi plugins, can be versioned,
with suffix .so.*
Add support in ipmid to find and load versioned libraries.
There seems to not be an issue if ipmid loads the same library
twice (a non-versioned and versioned) as with the cases where
a symlink .so points to a .so.* library.
Change-Id: I96d73e90dfec01c1a830dab4e6c20797b6130528
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|\
| |
| | |
Fix two issues in Issue #80
|
|/
|
|
|
|
|
|
| |
Corrected the comment for the Get Channel Info command to
reflect the logic in the code. For issue two, corrected the
condition for returning the unspecifed error.
Fixes openbmc/phosphor-host-ipmid#80
|
|\
| |
| | |
Fix minor fw revision to be BCD encoded
|