diff options
author | Nan Li <william.bjlinan@hotmail.com> | 2016-08-29 00:11:10 +0800 |
---|---|---|
committer | Patrick Williams <patrick@stwcx.xyz> | 2016-09-09 20:54:57 +0000 |
commit | 70aa8d9677b13eb97e71bc758a09e14e37053565 (patch) | |
tree | e42b5465c43bb01fd44ee0c840a89558d694a41f | |
parent | 37af73315c3e1ff504db466b10e6269cc56dcc6c (diff) | |
download | phosphor-host-ipmid-70aa8d9677b13eb97e71bc758a09e14e37053565.tar.gz phosphor-host-ipmid-70aa8d9677b13eb97e71bc758a09e14e37053565.zip |
Modify respond of un-supported IPMI command
A number of callbacks are registered for 'WILDCARD' types, which
currently do nothing except respond with CC_OK(00h). Change complete
codes to CC_INVALID(C1h).
Resolves openbmc/openbmc#469.
Change-Id: I91ea5ee1a23284a4159ff1c1867342e89c6fa444
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>
-rw-r--r-- | apphandler.cpp | 2 | ||||
-rw-r--r-- | chassishandler.cpp | 2 | ||||
-rw-r--r-- | sensorhandler.cpp | 2 | ||||
-rw-r--r-- | storagehandler.cpp | 2 | ||||
-rw-r--r-- | transporthandler.cpp | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/apphandler.cpp b/apphandler.cpp index 8da85e4..7b64c76 100644 --- a/apphandler.cpp +++ b/apphandler.cpp @@ -556,7 +556,7 @@ ipmi_ret_t ipmi_app_wildcard_handler(ipmi_netfn_t netfn, ipmi_cmd_t cmd, printf("Handling WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd); // Status code. - ipmi_ret_t rc = IPMI_CC_OK; + ipmi_ret_t rc = IPMI_CC_INVALID; *data_len = strlen("THIS IS WILDCARD"); diff --git a/chassishandler.cpp b/chassishandler.cpp index 2952725..9a5f169 100644 --- a/chassishandler.cpp +++ b/chassishandler.cpp @@ -491,7 +491,7 @@ ipmi_ret_t ipmi_chassis_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd, { printf("Handling CHASSIS WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd); // Status code. - ipmi_ret_t rc = IPMI_CC_OK; + ipmi_ret_t rc = IPMI_CC_INVALID; *data_len = 0; return rc; } diff --git a/sensorhandler.cpp b/sensorhandler.cpp index ea8099d..f906921 100644 --- a/sensorhandler.cpp +++ b/sensorhandler.cpp @@ -235,7 +235,7 @@ ipmi_ret_t ipmi_sen_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd, ipmi_request_t request, ipmi_response_t response, ipmi_data_len_t data_len, ipmi_context_t context) { - ipmi_ret_t rc = IPMI_CC_OK; + ipmi_ret_t rc = IPMI_CC_INVALID; printf("IPMI S/E Wildcard Netfn:[0x%X], Cmd:[0x%X]\n",netfn,cmd); *data_len = 0; diff --git a/storagehandler.cpp b/storagehandler.cpp index 9379b0d..01dd41a 100644 --- a/storagehandler.cpp +++ b/storagehandler.cpp @@ -21,7 +21,7 @@ ipmi_ret_t ipmi_storage_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd, { printf("Handling STORAGE WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd); // Status code. - ipmi_ret_t rc = IPMI_CC_OK; + ipmi_ret_t rc = IPMI_CC_INVALID; *data_len = 0; return rc; } diff --git a/transporthandler.cpp b/transporthandler.cpp index f7a029b..01a79cb 100644 --- a/transporthandler.cpp +++ b/transporthandler.cpp @@ -135,7 +135,7 @@ ipmi_ret_t ipmi_transport_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd, { printf("Handling TRANSPORT WILDCARD Netfn:[0x%X], Cmd:[0x%X]\n",netfn, cmd); // Status code. - ipmi_ret_t rc = IPMI_CC_OK; + ipmi_ret_t rc = IPMI_CC_INVALID; *data_len = 0; return rc; } |