| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
The enum definition for Chassis net functions in chassishandler.h
is wrong.
It should be defined as ipmi_netfn_chassis_cmds but not
ipmi_netfn_app_cmds which is defined in apphandler.h.
Change-Id: I26680d19b8c3be7ae2f832f851149352f0ed6303
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
|
|
|
|
|
|
|
| |
This is parallel to other functions defined in utils.hpp
Change-Id: I8f40e27d1a179258df5059c27066c8cd1b37a260
Signed-off-by: Vernon Mauery <vernon.mauery@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
-FRU's Mfg Date/Time is the number of minutes from 0:00 hrs
1/1/96 and a 3 byte field length for Mfg Data/Time in Board Info Area.
-So max Mfg date equals to 1006632900 secs from 00:00:00 hrs 1/1/1996.
Resolves openbmc/openbmc#3202
Change-Id: I6a71b8b881b699195fee2a18b743e195fa4703a5
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
| |
Until Issue #3325 is resolved, this will make the CI stable again.
Change-Id: I5156f1fed153586512d184c973a8be4036620d19
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OemRouter adds a facility to register OEM Group Message handlers,
then dispatch matching messages to the registered handler.
Added as a core source so that any dynamic provider can register its
messages without requiring any specific load order.
Includes code fixes for x86 portability.
Change-Id: I47b8fe7873e3c7fdf35a00d3c8a7e17d30c398c4
Signed-off-by: Peter Hanson <peterh@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the RequestedHostTransition property changes to On, clear
any pending commands in the command queue. This is done to avoid
race conditions around state transitions as well as other
scenarios like the following:
1) Host is already off
2) RequestedHostTransition is set to Off
3) RequestedHostTransition is set to On
4) Host powers on
5) Host immediately powers off because of the pending command
sent in 2).
Resolves openbmc/openbmc#3207
Tested: Verified the scenario above no longer occurs.
Change-Id: I26c8195c305c75b01333d1b10ff4bf16d76b91a6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
| |
The ipmitool commands are placed in the code block.
Change-Id: I787dff9d6acd77ceaa1c6251b4287c2367212cad
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any unhandled exception in the IPMI command handler
crashes the ipmi stack. IPMI command handler also becomes
bulky to catch all exceptions which must return unspecified
errors. This fix adds a catch in the ipmi router command handler
functions, and returns IPMI_CC_UNSPECIFIED_ERROR for all the
unhandled exceptions. With this fix, exceptions which has to
throw IPMI_CC_UNSPECIFIED_ERROR, doesn't needs to be handled in the
command handlers.
Change-Id: I6cf9fa1f0e5c1d71c57eebb9a2d451fa986168d3
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
|
|
|
|
|
|
|
|
| |
This patch adds error handling around the decoding of requests to the
watchdog service, to give more useful context in the case of errors.
Change-Id: If668b17e88dc65a938b69d8c2cdd760456170962
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
| |
Change-Id: I940aadefdf0f78182aad1d4e586e3178e2d2fe97
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
|
|
|
|
|
|
|
| |
Adding the network configuration commands
Change-Id: I0542e1266d3bf71c813c3d449bb2838f0dc887cf
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
| |
ipmi::Value is used as the type in setDbusProperty. As
properties are allowed to be doubles, add it to the type.
Change-Id: I3d2dd5063100b8e73732740ce056fc476a7e1e44
Signed-off-by: James Feist <james.feist@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
| |
Fixes issues with data passed to phosphor::logging::log(entry()).
This is part of a series of commits that resolves openbmc 2905.
Tested: static_assert only
Change-Id: I9fac771f54e4acbec97ce1360c106b6e3eb4fe9d
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Noticed D-bus method invoked as part of the callback method
invoked from async thread returns error
Switching to use sd_event loop timer for callback after timer
expiry
Resolves openbmc/openbmc#3130
Change-Id: Ibe87a6b3aa179cc887593c7dea635c11d9ea844c
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
| |
Proposing myself as a reviewer.
Change-Id: Ie5303cf029980deeced20764d98b86dd7012aff5
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Since we switched to resetting the watchdog with a built-in method, we
are only using a single property from the watchdog. Instead of fetching
all the properties and reading just the initialized one, only request
the initialized property from the watchdog.
Change-Id: I5e29b5100629e1ce23f352b0b749a434cd1ab793
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
Using this helper method reduces the number of dbus calls made during
each watchdog reset.
Change-Id: I373db3babe03e05fca33eb4dbbbc7c07f95a39ea
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
We want to better adhere to the openbmc convention of logging our errors
and reporting and internal exception upstack.
Change-Id: I78a277ed564b1ac269d84c024b75d2b0f534e911
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
| |
An upcoming change will introduce InternalFailures instead of using
runtime exceptions for error handling in the watchdog service. We need
to handle these exceptions appropriately.
Change-Id: Icfc02d98821f307a37a4cf59911913c820e88744
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
|
| |
It returns a counter value proportional to the system operating
power-on hours.
Partially Resolves openbmc/openbmc#2979
Change-Id: Ib0cd43fe5cbc055ae84991577d766bedae58d775
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now if the phosphor-watchdog gets restarted, the first ipmi
request querying it will fail and return all the way back up to the ipmi
client. In this case, it would be nicer for the client if we retried the
request once before reporting a failure.
Resolves openbmc/phosphor-host-ipmid#111
Change-Id: I73fce5431911279f9c2e4389d32b671ed60c2305
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
| |
Some of our apps may want to know if the ServiceCache was determined to
be valid prior to using it, so that they can retry their request in case
the cache was stale.
Change-Id: I106f11a18cd2290df9c18f29a8e779aacb5ef552
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get boot options is returning wrong value when
boot device is set to cdrom followed by setting boot
device to bios.
In the IPMI spec the boot device selector has options
for both "boot source" (default/disk/crdom/network)
and "boot mode" (default/bios/safe/diag). Since this
isn't a bit field, you can't override for eg both the
source and mode at the same time.
The solution is if a set boot device is mapping to a boot
source, then reset the boot mode D-Bus property to default,
or vice versa. This way the ipmid code can determine which
property is not at the default value
Resolves openbmc/openbmc#3067
Resolves openbmc/openbmc#3068
Change-Id: I072c82a161d56f118510fe1f9e5c75cb5c610295
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
setBootMode and setBootSource methods are introduced
by refactoring code from ipmi_chassis_set_sys_boot_options
for code reuse.
Change-Id: I30b641239686b0411a0995468d098f5ad3d61754
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
log<level::DEBUG> is not putting Host time into journal, instead it is
putting it in the metadata. Made fix for it.
Testing:
ipmitool sel time get # Host time:xxx XXX x xx:xx:xx xxxx will be
# printed in into journal
Change-Id: I0ba72a871469a30c605ee3ec91a07787959d5ae3
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue here is that for derating factor sensor read command,
hostboot is expecting return value in event_status field, but we are
sending it in sensor reading field.
Testing:
ipmitool raw 0x04 0x2d 0xd8 #it has to retrun "00 00 5a 00"
Resolves openbmc/openbmc#3012
Change-Id: I09e3d02c946ad1d8a39ea747fc400fb623cbe6ef
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
The offset length is validated against the size of the FRU area,
before proceeding with populating the response of the Read FRU command.
Resolves openbmc/openbmc#3132
Change-Id: I2bc660b7e389f5c85bac0acc8068dd53ab328a65
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I0d8205b378ab5044f58f528aad3b4fab7c993044
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
The completion code is the return parameter for the registered functions
so should not be part of the response structure. Client applications like
ipmitool will get the size wrong.
Change-Id: Ibe082096f5002948f01636c6dfd7e54fadced2ef
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Id93e51694e527790209ad4511e4cefb154fe9887
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Validate FRU Id before proceesing with the command handling.
Do not report error log for any FRU command failure, since IPMI is
an external interface.
Resolves openbmc/openbmc#3016
Change-Id: I9e2af3ce50285662f1b8f9600222e9ff3057a7e3
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I3a58137b3300fcfe51a4182eb304a1b70885ad30
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Some additional grammar and capitalization errors were fixed as well.
Change-Id: I700db4e6d7ba52b02374c9c3e84be0af8bd91859
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
| |
replaced tabs with four spaces.
Change-Id: Ib36bf7956a280921c45a7944a972c0f19fe39e5c
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Ic78965be94b1ba31149a05a29c1a768f06b492e4
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.
Partially Resolves openbmc/openbmc#2507
Change-Id: I749c19c18d1cabf6f0216830c8cb0a08ee43d6de
Signed-off-by: Aditya Saripalli <aditya0124@gmail.com>
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When BMC exports the date into DBUS it translates/expands the 3 bytes FRU
format date into an easy to read string as in "2015-11-06 - 22:23:00", when
exporting the DBUS date back to IPMI it needs to translate back this date
into the 3 bytes FRU format, without this fix we get a build date in 1996
that is the epoch for the FRU date format. This change reconstructs the
FRU date from the easy to read string for exporting into IPMI.
Tested: Manual check that BuildDate from busctl and ipmitool match
Resolves openbmc/openbmc#3013
Change-Id: I0fd1dd8f945f18b53c14bff321c9e233fdb2d742
Signed-off-by: Andres Oportus <andresoportus@google.com>
|
|
|
|
|
| |
Change-Id: I8c808ce7e2bbd3ae5e225573138d7e04871f1643
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Changed mutability handling error code in get sensor
from IPMI_CC_SENSOR_INVALID to IPMI_CC_ILLEGAL_COMMAND
Change-Id: I599de08e3d3bc6a9820ac3978f0a4d160f19f55e
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2980
Change-Id: I67afd4e84ec96e5cfc2dd315604d70f41c67a438
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mapping between an error level in the esel to a phosphor-logging
error level was broken. This commit fixes it.
This commits also specifies the error level while calling the error
report() API, so that error D-Bus objects reflect the right error level
(as per the esel).
Resolves openbmc/openbmc#3014.
Change-Id: I9891d468d98d169f73275a3693df4f3a2166001d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a sensor id is not managed in yaml the code tries to get it from
legacy SystemManager;
And when the sensor id can not be found in SystemManager, it returns
empty path, and cause segment fault.
This commit makes it return -EINVAL when path is empty, and thus the
code will handle this case properly without crash.
Resolves openbmc/openbmc#3062
Tested: Boot host without ipmid crash on Romulus.
Change-Id: I4240b9be54824543b5e795e898330aeb02c5eb90
Signed-off-by: Lei YU <mine260309@gmail.com>
|
|
|
|
|
|
|
| |
Reworded cleaning the repo. The old wording did not make sense.
Change-Id: I129faed7b8de5781c4f67e77be6122937e4a6e5d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 82feb17d0c244ed04b82b0fbed3c0a9456986a86.
The fix for armv5 futures is provided in yocto 2.4
Resolves openbmc/openbmc#3010
Change-Id: Ifc7e224f6f1fa115e0299642e8866b82d6e4f38c
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we are doing interface + path -> service lookups for each ipmi
command sent to the daemon. For many types of commands this is not ideal
as the daemon is unlikely to change often at runtime. Implement a basic
cache with the ability to invalidate the service name at any time. This
is used by code in a future commit.
Change-Id: I85b04dd17ac19e31d49070f289704b429bd1e577
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have occasionally noticed that the watchdog will be enabled and then
immediately trip upon booting of the BMC. This happens if the host is
still running when the BMC is coming up. Digging into the issue we notice
that the phosphor-mapper can be under very heavy load responding to all
of the initial mapping requests from BMC daemons starting. This causes a
delay in the phosphor-watchdog service name lookup during an attempt to
reset the watchdog countdown. The lookup delay is so long that the
watchdog ends up tripping before the reset is actually issued, causing
the BMC to reset the host. Since we know that the watchdog will not be
armed until the service resolves for the first time, we can reduce the
dependence and pressure on the service mapper by caching the service
name. Since it is the case that we want to keep issuing resets to the
same daemon that was initially configured, we should have no worries
about invalidating the cached service name. The name will be invalidated
any time we encounter a dbus level error issuing a watchdog commmand.
Change-Id: I303a39be997c2e57050b71efc8ef2e2cb27f8cf7
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed below given two issues:
1.We are getting seg-fault due to incorrect format specifiers for log-entry.
2.When requested data count plus offset exceeds fruArea size, we through error,
instead we can return remaining bytes.
Tested:
1.Verified using below given command.
ipmitool -I lanplus -C 3 -P 0penBmc -H <BMP_IP> fru read <fru_id> fru_file
Resolves openbmc/openbmc#2893
Change-Id: Iecfe80ed7230b936eca86fd16208582ee7b4e09c
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Change-Id: I1d0551f8b7ceb7f74a975cae0a35ced15c01a74d
Tested: Built the repo
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Presently when partial lan data is given the code
was not getting the correct IP object,it was getting
the linklocal address.
This defect was introduced due to this commit c7c1c3c.
This commit fixes this problem.
Change-Id: I8f6d915cd3e1757ba28394cd93f16396e087d4f7
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start the timer once the set in progress parameter set to
set complete as part of Set LAN Configuration Parameters
command.
Resolves openbmc/openbmc#2932
Resolves openbmc/openbmc#2993
Change-Id: Ie6f3b331531da23c74fa44bb52fa1ddccffabd13
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|