diff options
author | Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> | 2018-12-03 15:08:59 +0530 |
---|---|---|
committer | Vernon Mauery <vernon.mauery@linux.intel.com> | 2018-12-11 14:29:30 +0000 |
commit | a45cb34ff6e6c778e2d2b86518afb8bc0a54d189 (patch) | |
tree | 605604911d40cc575c6be9fa927e6922de1e571c /user_channel/user_layer.cpp | |
parent | ae4b040bd08839efcbc08a78d4f6ce6d77e66050 (diff) | |
download | phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.tar.gz phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.zip |
Update const uint8_t& to const uint8_t
Update const uint8_t& to const uint8_t usage. Passing by reference
for small types are costly than passing it by value and hence the
change is done
Unit-Test
1. Performed build and verified regular user account creation
and RMCP+ login
Change-Id: Ic2dd76795749148f82564677dde2a5db08520454
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Diffstat (limited to 'user_channel/user_layer.cpp')
-rw-r--r-- | user_channel/user_layer.cpp | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/user_channel/user_layer.cpp b/user_channel/user_layer.cpp index 5a4d7ad..30aa12c 100644 --- a/user_channel/user_layer.cpp +++ b/user_channel/user_layer.cpp @@ -57,17 +57,17 @@ ipmi_ret_t ipmiRenameUserEntryPassword(const std::string& userName, return IPMI_CC_OK; } -bool ipmiUserIsValidUserId(const uint8_t& userId) +bool ipmiUserIsValidUserId(const uint8_t userId) { return UserAccess::isValidUserId(userId); } -bool ipmiUserIsValidChannel(const uint8_t& chNum) +bool ipmiUserIsValidChannel(const uint8_t chNum) { return UserAccess::isValidChannel(chNum); } -bool ipmiUserIsValidPrivilege(const uint8_t& priv) +bool ipmiUserIsValidPrivilege(const uint8_t priv) { return UserAccess::isValidPrivilege(priv); } @@ -77,12 +77,12 @@ uint8_t ipmiUserGetUserId(const std::string& userName) return getUserAccessObject().getUserId(userName); } -ipmi_ret_t ipmiUserSetUserName(const uint8_t& userId, const char* userName) +ipmi_ret_t ipmiUserSetUserName(const uint8_t userId, const char* userName) { return getUserAccessObject().setUserName(userId, userName); } -ipmi_ret_t ipmiUserGetUserName(const uint8_t& userId, std::string& userName) +ipmi_ret_t ipmiUserGetUserName(const uint8_t userId, std::string& userName) { return getUserAccessObject().getUserName(userId, userName); } @@ -109,12 +109,12 @@ ipmi_ret_t ipmiUserGetAllCounts(uint8_t& maxChUsers, uint8_t& enabledUsers, return IPMI_CC_OK; } -ipmi_ret_t ipmiUserUpdateEnabledState(const uint8_t& userId, const bool& state) +ipmi_ret_t ipmiUserUpdateEnabledState(const uint8_t userId, const bool& state) { return getUserAccessObject().setUserEnabledState(userId, state); } -ipmi_ret_t ipmiUserCheckEnabled(const uint8_t& userId, bool& state) +ipmi_ret_t ipmiUserCheckEnabled(const uint8_t userId, bool& state) { if (!UserAccess::isValidUserId(userId)) { @@ -125,8 +125,7 @@ ipmi_ret_t ipmiUserCheckEnabled(const uint8_t& userId, bool& state) return IPMI_CC_OK; } -ipmi_ret_t ipmiUserGetPrivilegeAccess(const uint8_t& userId, - const uint8_t& chNum, +ipmi_ret_t ipmiUserGetPrivilegeAccess(const uint8_t userId, const uint8_t chNum, PrivAccess& privAccess) { @@ -148,8 +147,7 @@ ipmi_ret_t ipmiUserGetPrivilegeAccess(const uint8_t& userId, return IPMI_CC_OK; } -ipmi_ret_t ipmiUserSetPrivilegeAccess(const uint8_t& userId, - const uint8_t& chNum, +ipmi_ret_t ipmiUserSetPrivilegeAccess(const uint8_t userId, const uint8_t chNum, const PrivAccess& privAccess, const bool& otherPrivUpdates) { |