summaryrefslogtreecommitdiffstats
path: root/user_channel/channel_layer.hpp
diff options
context:
space:
mode:
authorRichard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>2018-12-03 15:08:59 +0530
committerVernon Mauery <vernon.mauery@linux.intel.com>2018-12-11 14:29:30 +0000
commita45cb34ff6e6c778e2d2b86518afb8bc0a54d189 (patch)
tree605604911d40cc575c6be9fa927e6922de1e571c /user_channel/channel_layer.hpp
parentae4b040bd08839efcbc08a78d4f6ce6d77e66050 (diff)
downloadphosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.tar.gz
phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.zip
Update const uint8_t& to const uint8_t
Update const uint8_t& to const uint8_t usage. Passing by reference for small types are costly than passing it by value and hence the change is done Unit-Test 1. Performed build and verified regular user account creation and RMCP+ login Change-Id: Ic2dd76795749148f82564677dde2a5db08520454 Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Diffstat (limited to 'user_channel/channel_layer.hpp')
-rw-r--r--user_channel/channel_layer.hpp32
1 files changed, 16 insertions, 16 deletions
diff --git a/user_channel/channel_layer.hpp b/user_channel/channel_layer.hpp
index fa15378..3a9b5f5 100644
--- a/user_channel/channel_layer.hpp
+++ b/user_channel/channel_layer.hpp
@@ -142,7 +142,7 @@ struct ChannelInfo
*
* @return true if valid, false otherwise
*/
-bool isValidChannel(const uint8_t& chNum);
+bool isValidChannel(const uint8_t chNum);
/** @brief determines whether channel device exist
*
@@ -150,7 +150,7 @@ bool isValidChannel(const uint8_t& chNum);
*
* @return true if valid, false otherwise
*/
-bool doesDeviceExist(const uint8_t& chNum);
+bool doesDeviceExist(const uint8_t chNum);
/** @brief determines whether privilege limit is valid
*
@@ -158,7 +158,7 @@ bool doesDeviceExist(const uint8_t& chNum);
*
* @return true if valid, false otherwise
*/
-bool isValidPrivLimit(const uint8_t& privLimit);
+bool isValidPrivLimit(const uint8_t privLimit);
/** @brief determines whether access mode is valid
*
@@ -166,7 +166,7 @@ bool isValidPrivLimit(const uint8_t& privLimit);
*
* @return true if valid, false otherwise
*/
-bool isValidAccessMode(const uint8_t& accessMode);
+bool isValidAccessMode(const uint8_t accessMode);
/** @brief determines valid authentication type based on channel number
*
@@ -175,7 +175,7 @@ bool isValidAccessMode(const uint8_t& accessMode);
*
* @return true if valid, false otherwise
*/
-bool isValidAuthType(const uint8_t& chNum, const EAuthType& authType);
+bool isValidAuthType(const uint8_t chNum, const EAuthType& authType);
/** @brief determines supported session type of a channel
*
@@ -183,7 +183,7 @@ bool isValidAuthType(const uint8_t& chNum, const EAuthType& authType);
*
* @return EChannelSessSupported - supported session type
*/
-EChannelSessSupported getChannelSessionSupport(const uint8_t& chNum);
+EChannelSessSupported getChannelSessionSupport(const uint8_t chNum);
/** @brief determines number of active sessions on a channel
*
@@ -191,7 +191,7 @@ EChannelSessSupported getChannelSessionSupport(const uint8_t& chNum);
*
* @return numer of active sessions
*/
-int getChannelActiveSessions(const uint8_t& chNum);
+int getChannelActiveSessions(const uint8_t chNum);
/** @brief initializes channel management
*
@@ -206,7 +206,7 @@ ipmi_ret_t ipmiChannelInit();
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t getChannelInfo(const uint8_t& chNum, ChannelInfo& chInfo);
+ipmi_ret_t getChannelInfo(const uint8_t chNum, ChannelInfo& chInfo);
/** @brief provides channel access data
*
@@ -215,7 +215,7 @@ ipmi_ret_t getChannelInfo(const uint8_t& chNum, ChannelInfo& chInfo);
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t getChannelAccessData(const uint8_t& chNum,
+ipmi_ret_t getChannelAccessData(const uint8_t chNum,
ChannelAccess& chAccessData);
/** @brief to set channel access data
@@ -226,9 +226,9 @@ ipmi_ret_t getChannelAccessData(const uint8_t& chNum,
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t setChannelAccessData(const uint8_t& chNum,
+ipmi_ret_t setChannelAccessData(const uint8_t chNum,
const ChannelAccess& chAccessData,
- const uint8_t& setFlag);
+ const uint8_t setFlag);
/** @brief to get channel access data persistent data
*
@@ -237,7 +237,7 @@ ipmi_ret_t setChannelAccessData(const uint8_t& chNum,
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t getChannelAccessPersistData(const uint8_t& chNum,
+ipmi_ret_t getChannelAccessPersistData(const uint8_t chNum,
ChannelAccess& chAccessData);
/** @brief to set channel access data persistent data
@@ -248,9 +248,9 @@ ipmi_ret_t getChannelAccessPersistData(const uint8_t& chNum,
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t setChannelAccessPersistData(const uint8_t& chNum,
+ipmi_ret_t setChannelAccessPersistData(const uint8_t chNum,
const ChannelAccess& chAccessData,
- const uint8_t& setFlag);
+ const uint8_t setFlag);
/** @brief provides supported authentication type for the channel
*
@@ -259,7 +259,7 @@ ipmi_ret_t setChannelAccessPersistData(const uint8_t& chNum,
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t getChannelAuthTypeSupported(const uint8_t& chNum,
+ipmi_ret_t getChannelAuthTypeSupported(const uint8_t chNum,
uint8_t& authTypeSupported);
/** @brief provides enabled authentication type for the channel
@@ -270,7 +270,7 @@ ipmi_ret_t getChannelAuthTypeSupported(const uint8_t& chNum,
*
* @return IPMI_CC_OK for success, others for failure.
*/
-ipmi_ret_t getChannelEnabledAuthType(const uint8_t& chNum, const uint8_t& priv,
+ipmi_ret_t getChannelEnabledAuthType(const uint8_t chNum, const uint8_t priv,
EAuthType& authType);
} // namespace ipmi
OpenPOWER on IntegriCloud