diff options
| author | Nagaraju Goruganti <ngorugan@in.ibm.com> | 2018-03-21 11:18:30 -0500 |
|---|---|---|
| committer | Tom Joseph <tomjoseph@in.ibm.com> | 2018-03-27 08:33:29 +0000 |
| commit | 7f2d7c90a27aacb45fa5ccc18c777593e007d2a7 (patch) | |
| tree | 15076e9d22b4ccfef92e97663f6359228d5a71e4 /storagehandler.h | |
| parent | 8466b792959984e6b02eadb1cdf02d1868373401 (diff) | |
| download | phosphor-host-ipmid-7f2d7c90a27aacb45fa5ccc18c777593e007d2a7.tar.gz phosphor-host-ipmid-7f2d7c90a27aacb45fa5ccc18c777593e007d2a7.zip | |
Fixed broken "fru read" command
Fixed below given two issues:
1.We are getting seg-fault due to incorrect format specifiers for log-entry.
2.When requested data count plus offset exceeds fruArea size, we through error,
instead we can return remaining bytes.
Tested:
1.Verified using below given command.
ipmitool -I lanplus -C 3 -P 0penBmc -H <BMP_IP> fru read <fru_id> fru_file
Resolves openbmc/openbmc#2893
Change-Id: Iecfe80ed7230b936eca86fd16208582ee7b4e09c
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
Diffstat (limited to 'storagehandler.h')
| -rw-r--r-- | storagehandler.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/storagehandler.h b/storagehandler.h index 1849fc7..009b281 100644 --- a/storagehandler.h +++ b/storagehandler.h @@ -46,6 +46,15 @@ struct ReadFruDataRequest }__attribute__ ((packed)); /** + * @struct Read FRU Data command response data + */ +struct ReadFruDataResponse +{ + uint8_t count; ///< Response data Count. + uint8_t data[]; ///< Response data. +}__attribute__ ((packed)); + +/** * @struct Get FRU inventory area info command request data */ struct FruInvenAreaInfoRequest |
