summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVernon Mauery <vernon.mauery@linux.intel.com>2019-11-07 09:51:39 -0800
committerVernon Mauery <vernon.mauery@linux.intel.com>2019-11-11 10:24:03 -0800
commit79b4eeaa0c97b40d9ab12b48694083cec2b13d79 (patch)
tree035b2b8a3efffb2dc6a55c210623a4ee49a33b7f
parent9fc5fa180c3dc0a4fa5ed02efe4b990c40ba641d (diff)
downloadphosphor-host-ipmid-79b4eeaa0c97b40d9ab12b48694083cec2b13d79.tar.gz
phosphor-host-ipmid-79b4eeaa0c97b40d9ab12b48694083cec2b13d79.zip
Fix permissions on Get Channel Cipher Suites command
The Get Channel Cipher Suites command should be available at any privilege level as well as pre-session. This changes it so that it can be used pre-session to determine the best cipher suite to use. As per section 22.15 of the IPMI 2.0 spec, "This command can be executed prior to establishing a session with the BMC." This means that it should be able to be executed at any privilege, including 'none'. Tested: run a new version of ipmitool that calls get channel cipher suite as part of session initialization before and after. This affects all commands, but raw is the shortest to run, so it is used here. (raw 6 1 is get device id). Before: $ ipmitool -I lanplus -H a.b.c.d -U root -P 0penBmc raw 6 1 Get Channel Cipher Suites failed: Insufficient privilege level 23 00 00 01 02 bf 57 01 00 7b 00 99 91 cd 13 After: $ ipmitool -I lanplus -H a.b.c.d -U root -P 0penBmc raw 6 1 23 00 00 01 02 bf 57 01 00 7b 00 99 91 cd 13 Change-Id: I59a3212f1ea5dc82c545e6ec1ee4a437ec5abfe1 Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
-rw-r--r--apphandler.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/apphandler.cpp b/apphandler.cpp
index 03cd255..ba1c439 100644
--- a/apphandler.cpp
+++ b/apphandler.cpp
@@ -1694,7 +1694,7 @@ void register_netfn_app_functions()
// <Get Channel Cipher Suites Command>
ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnApp,
ipmi::app::cmdGetChannelCipherSuites,
- ipmi::Privilege::Callback, getChannelCipherSuites);
+ ipmi::Privilege::None, getChannelCipherSuites);
// <Get System Info Command>
ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnApp,
OpenPOWER on IntegriCloud