summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2019-02-13 15:34:39 -0800
committerPatrick Venture <venture@google.com>2019-02-13 15:34:39 -0800
commit47044e6c86332cf4ba878c85bec362eb616fc7df (patch)
treeab16df8410bedb6b13050d57eb142aaa76285074
parent1dc2b79e3494cd27fabecbbc62cc3013c652ae88 (diff)
downloadphosphor-gpio-monitor-47044e6c86332cf4ba878c85bec362eb616fc7df.zip
phosphor-gpio-monitor-47044e6c86332cf4ba878c85bec362eb616fc7df.tar.gz
build: pkg anti-pattern: use defaultsHEADmaster
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: If3a19a3857645dc36d48b3d849d1d6a222a8cfbb Signed-off-by: Patrick Venture <venture@google.com>
-rw-r--r--configure.ac10
1 files changed, 5 insertions, 5 deletions
diff --git a/configure.ac b/configure.ac
index 2217485..e411825 100644
--- a/configure.ac
+++ b/configure.ac
@@ -18,11 +18,11 @@ AX_APPEND_COMPILE_FLAGS([-Wall -Werror], [CXXFLAGS])
LT_INIT
# Checks for modules
-PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221], ,[AC_MSG_ERROR([Could not find systemd...systemd development package required])])
-PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],, [AC_MSG_ERROR([Could not find phosphor-logging...openbmc/phosphor-logging package required])])
-PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],, [AC_MSG_ERROR([Could not find sdbusplus...openbmc/sdbusplus package required])])
-PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces],, [AC_MSG_ERROR([Could not find phosphor-dbus-interfaces...openbmc/phosphor-dbus-interfaces package required])])
-PKG_CHECK_MODULES([LIBEVDEV], [libevdev],, [AC_MSG_ERROR([Could not find libevdev...libevdev package required])])
+PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221])
+PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging])
+PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus])
+PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces])
+PKG_CHECK_MODULES([LIBEVDEV], [libevdev])
# Download gpio.h from github if necessary.
AC_CHECK_HEADER(linux/gpio.h,[HAVE_LINUX_GPIO_H=""],[HAVE_LINUX_GPIO_H="-I linux/gpio.h"])
OpenPOWER on IntegriCloud