summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2019-02-13 15:26:00 -0800
committerPatrick Venture <venture@google.com>2019-02-13 15:26:00 -0800
commitefd8e9106a73c99d84dbafaf4f9348fca9abd1c0 (patch)
treed59a3fbf777a82887c4772fd98cca5572551af80
parent991af7ecfb579e72613b6c2ab5036a4dc7834636 (diff)
downloadphosphor-bmc-code-mgmt-efd8e9106a73c99d84dbafaf4f9348fca9abd1c0.zip
phosphor-bmc-code-mgmt-efd8e9106a73c99d84dbafaf4f9348fca9abd1c0.tar.gz
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: I505ebc57cc86595df294d6e9cf7e57513ffc3aa5 Signed-off-by: Patrick Venture <venture@google.com>
-rwxr-xr-xconfigure.ac9
1 files changed, 3 insertions, 6 deletions
diff --git a/configure.ac b/configure.ac
index 4fa36d3..8e31832 100755
--- a/configure.ac
+++ b/configure.ac
@@ -12,12 +12,9 @@ AC_PROG_MAKE_SET
# Check for libraries
PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221])
-PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces],,\
- AC_MSG_ERROR(["Requires phosphor-dbus-interfaces package."]))
-PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],,
- AC_MSG_ERROR(["Requires sdbusplus package."]))
-PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],,\
- AC_MSG_ERROR(["Requires phosphor-logging package."]))
+PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces])
+PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus])
+PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging])
# Check for sdbus++
AC_PATH_PROG([SDBUSPLUSPLUS], [sdbus++])
AS_IF([test "x$SDBUSPLUSPLUS" == "x"],
OpenPOWER on IntegriCloud