summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLei YU <mine260309@gmail.com>2019-02-25 16:01:45 +0800
committerLei YU <mine260309@gmail.com>2019-03-07 10:46:57 +0800
commiteaa9b07637e457392f89e83194b2d818c9dfa9cb (patch)
tree9e89e8bcd59ce85415c47cf041eae04789f27c0a
parentbee5140642e935c266766906d41d3712da04d6ff (diff)
downloadopenpower-pnor-code-mgmt-eaa9b07637e457392f89e83194b2d818c9dfa9cb.tar.gz
openpower-pnor-code-mgmt-eaa9b07637e457392f89e83194b2d818c9dfa9cb.zip
Refactor: Remove unused isLowestPriority()
The function isLowestPriority() is not used, remove it. Tested: On the last commit of the patch series, run code update and factory reset on Witherspoon and all work fine. Change-Id: Ib71ce5b9ad0319f8d7db3442d507c3fee7aba7fa Signed-off-by: Lei YU <mine260309@gmail.com>
-rw-r--r--item_updater.hpp9
-rw-r--r--ubi/item_updater_ubi.cpp15
-rw-r--r--ubi/item_updater_ubi.hpp2
3 files changed, 0 insertions, 26 deletions
diff --git a/item_updater.hpp b/item_updater.hpp
index 7a67d6969..0e4c45c0f 100644
--- a/item_updater.hpp
+++ b/item_updater.hpp
@@ -103,15 +103,6 @@ class ItemUpdater : public ItemUpdaterInherit
*/
virtual void freePriority(uint8_t value, const std::string& versionId) = 0;
- /** @brief Determine is the given priority is the lowest
- *
- * @param[in] value - The priority that needs to be checked.
- *
- * @return boolean corresponding to whether the given
- * priority is lowest.
- */
- virtual bool isLowestPriority(uint8_t value) = 0;
-
/**
* @brief Create and populate the active PNOR Version.
*/
diff --git a/ubi/item_updater_ubi.cpp b/ubi/item_updater_ubi.cpp
index 354610b81..7a6424451 100644
--- a/ubi/item_updater_ubi.cpp
+++ b/ubi/item_updater_ubi.cpp
@@ -391,21 +391,6 @@ void ItemUpdaterUbi::freePriority(uint8_t value, const std::string& versionId)
}
}
-bool ItemUpdaterUbi::isLowestPriority(uint8_t value)
-{
- for (const auto& intf : activations)
- {
- if (intf.second->redundancyPriority)
- {
- if (intf.second->redundancyPriority.get()->priority() < value)
- {
- return false;
- }
- }
- }
- return true;
-}
-
bool ItemUpdaterUbi::erase(std::string entryId)
{
if (!ItemUpdater::erase(entryId))
diff --git a/ubi/item_updater_ubi.hpp b/ubi/item_updater_ubi.hpp
index dfc8e530a..ec9d05c53 100644
--- a/ubi/item_updater_ubi.hpp
+++ b/ubi/item_updater_ubi.hpp
@@ -29,8 +29,6 @@ class ItemUpdaterUbi : public ItemUpdater
void freePriority(uint8_t value, const std::string& versionId) override;
- bool isLowestPriority(uint8_t value) override;
-
void processPNORImage() override;
bool erase(std::string entryId) override;
OpenPOWER on IntegriCloud