summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSaqib Khan <khansa@us.ibm.com>2017-07-10 17:24:43 -0500
committerSaqib Khan <khansa@us.ibm.com>2017-07-11 08:35:09 -0500
commit00044f4fdd179a2cfefc4b53615772f5742b6921 (patch)
tree6d00d9f745debdc47bb5fba2c91b42005d247618
parent1793b648efbe4d5446f0a53d12381d1b34776cbf (diff)
downloadopenpower-pnor-code-mgmt-00044f4fdd179a2cfefc4b53615772f5742b6921.tar.gz
openpower-pnor-code-mgmt-00044f4fdd179a2cfefc4b53615772f5742b6921.zip
Prevent Host Updater from going in to an infinite loop.
The incorrect postion of the curly bracket caused the Host Updater to create a new version object and to call itself with out checking if the same version exists already. Resolves openbmc/openbmc#1923 Change-Id: Ide8f98d67604a9ade272e69e20780f21cac01e0c Signed-off-by: Saqib Khan <khansa@us.ibm.com>
-rwxr-xr-xitem_updater.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/item_updater.cpp b/item_updater.cpp
index bf4ba387c..3edfb0c01 100755
--- a/item_updater.cpp
+++ b/item_updater.cpp
@@ -111,7 +111,6 @@ void ItemUpdater::createActivation(sdbusplus::message::message& m)
versionId,
extendedVersion,
activationState)));
- }
versions.insert(std::make_pair(
versionId,
std::make_unique<Version>(
@@ -120,6 +119,7 @@ void ItemUpdater::createActivation(sdbusplus::message::message& m)
version,
purpose,
filePath)));
+ }
return;
}
OpenPOWER on IntegriCloud