diff options
author | Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> | 2017-08-29 14:09:35 +0530 |
---|---|---|
committer | Patrick Williams <patrick@stwcx.xyz> | 2017-09-01 15:48:12 +0000 |
commit | 18dc1281fe5af83c1dbb9c8895d7af824d2c1856 (patch) | |
tree | 9407a71f881b0731a889f5fe5b1531ce2584f6d0 | |
parent | 6c56a4a82863859d0d593621dc86f2a576440e77 (diff) | |
download | openpower-occ-control-18dc1281fe5af83c1dbb9c8895d7af824d2c1856.tar.gz openpower-occ-control-18dc1281fe5af83c1dbb9c8895d7af824d2c1856.zip |
Change signature of getService
getService() has [bus, interface, path] as parameter and
the caller invoked it with [bus, path, interface] and that
resulted in a failure. Although the fix can be put into the
caller to pass the right arguments, better fix would be to
change the signature of getService() to receive path and then
the interface as that is what has been followed all over and
the deviation resulted in this bug.
Change-Id: I3efe7f4f0a2d0bceb7e6e801cd68de6b2624fbe0
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
-rw-r--r-- | utils.cpp | 4 | ||||
-rw-r--r-- | utils.hpp | 6 |
2 files changed, 5 insertions, 5 deletions
@@ -13,8 +13,8 @@ using InternalFailure = sdbusplus::xyz::openbmc_project::Common:: Error::InternalFailure; std::string getService(sdbusplus::bus::bus& bus, - const std::string& intf, - const std::string& path) + const std::string& path, + const std::string& intf) { auto mapperCall = bus.new_method_call("xyz.openbmc_project.ObjectMapper", "/xyz/openbmc_project/object_mapper", @@ -10,14 +10,14 @@ namespace occ * @brief Gets the D-Bus Service name for the input D-Bus path * * @param[in] bus - Bus handler - * @param[in] intf - Interface * @param[in] path - Object Path + * @param[in] intf - Interface * * @return Service name * @error InternalFailure exception thrown */ std::string getService(sdbusplus::bus::bus& bus, - const std::string& intf, - const std::string& path); + const std::string& path, + const std::string& intf); } // namespace occ } // namespace open_power |