summaryrefslogtreecommitdiffstats
path: root/maintainer-workflow.md
diff options
context:
space:
mode:
authorJoseph Reynolds <jrey@us.ibm.com>2018-06-29 14:25:52 -0500
committerGunnar Mills <gmills@us.ibm.com>2018-08-07 17:32:20 +0000
commit94b94e50f8122781c7bff389ee0cae6787c37db8 (patch)
treec8a13a611516fb3bc5524c9c7a30a36188727e95 /maintainer-workflow.md
parentd665475d14ee0d9ea388a77007f1667df372f85a (diff)
downloadopenbmc-docs-94b94e50f8122781c7bff389ee0cae6787c37db8.tar.gz
openbmc-docs-94b94e50f8122781c7bff389ee0cae6787c37db8.zip
Enhance CONTRIBUTING.md and maintainer-workflow.md
Added information about the mechanics of Gerrit-based code reviews, and about reviewers and maintainers. Change-Id: I378cb9a5d0a42c702374485271628d9cba9789d3 Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>
Diffstat (limited to 'maintainer-workflow.md')
-rw-r--r--maintainer-workflow.md20
1 files changed, 18 insertions, 2 deletions
diff --git a/maintainer-workflow.md b/maintainer-workflow.md
index 7482ac4..4c3c586 100644
--- a/maintainer-workflow.md
+++ b/maintainer-workflow.md
@@ -19,6 +19,23 @@ corporate) has been uploaded to the CLA repository.
* The ICLA form can be found [here]
(https://github.com/openbmc/openbmc/files/1860742/OpenBMC.ICLA.pdf).
+An executed OpenBMC CLA is _not_ required to accept contributions to
+OpenBMC forks of upstream projects, like the Linux kernel or U-Boot.
+
+Review the maintainers' responsibilities in the [contributing
+guidelines](./CONTRIBUTING.md). Maintainers are ultimately
+responsible for sorting out open source license issues, issues with
+using code copied from the web, and maintaining the quality of the
+code.
+
+Repository maintainers ought to have the following traits as
+recognized by a consensus of their peers:
+ - responsible: have a continuing desire to ensure only high-quality
+ code goes into the repo
+ - leadership: foster open-source aware practices such as [FOSS](https://en.wikipedia.org/wiki/Free_and_open-source_software)
+ - expertise: typically demonstrated by significant contributions to
+ the code or code reviews
+
(1) The semantics of accepting a patch depend on the sub-project contribution
process.
@@ -26,5 +43,4 @@ process.
* Gerrit - +2.
* email - Merging the patch.
-An executed OpenBMC CLA is _not_ required to accept contributions to
-OpenBMC forks of upstream projects, like the Linux kernel or U-Boot.
+Ensure that accepted changes actually merge into OpenBMC repositories.
OpenPOWER on IntegriCloud