diff options
author | Alexandre Oliva <lxoliva@fsfla.org> | 2011-10-29 08:43:10 +0000 |
---|---|---|
committer | Alexandre Oliva <lxoliva@fsfla.org> | 2011-10-29 08:43:10 +0000 |
commit | f713f558e4aaa7eaa8c4cc51e61671dc051ce28e (patch) | |
tree | 873cd1473c41f3eb4f098340f15bfe3a26d53d8c /freed-ora/current/f15/platform-fix-samsung-brightness-min-max-calculations.patch | |
parent | 4dd78bd36a6331aa7682bb91705c1c34231d2d1a (diff) | |
download | linux-libre-raptor-f713f558e4aaa7eaa8c4cc51e61671dc051ce28e.tar.gz linux-libre-raptor-f713f558e4aaa7eaa8c4cc51e61671dc051ce28e.zip |
2.6.40.8-2.fc15
Diffstat (limited to 'freed-ora/current/f15/platform-fix-samsung-brightness-min-max-calculations.patch')
-rw-r--r-- | freed-ora/current/f15/platform-fix-samsung-brightness-min-max-calculations.patch | 56 |
1 files changed, 56 insertions, 0 deletions
diff --git a/freed-ora/current/f15/platform-fix-samsung-brightness-min-max-calculations.patch b/freed-ora/current/f15/platform-fix-samsung-brightness-min-max-calculations.patch new file mode 100644 index 000000000..6a2c3b8cc --- /dev/null +++ b/freed-ora/current/f15/platform-fix-samsung-brightness-min-max-calculations.patch @@ -0,0 +1,56 @@ +From: Jason Stubbs <jasonbstubbs@gmail.com> +Subject: [PATCH] platform: fix samsung brightness min/max calculations + +For one of the SABI configs, the valid brightness levels are 1 through 8 with +0 being reserved for the BIOS. To make the range 0-based, the driver is meant +to offset values to/from userspace by 1 giving valid levels of 0 through 7. + +Currently, the driver is reporting a max brightness of 8 and doing the offset +the wrong way such that setting a brightness of 8 will set as 7 in hardware +while setting a brightness of 0 will attempt (and fail) to set as -1 in +hardware. + +This patch fixes these calculations as well as a potential miscalculation due +to an assumption of min_brightness being either 0 or 1. + +Signed-off-by: Jason Stubbs <jasonbstubbs@gmail.com> +Signed-off-by: Chuck Ebbert <cebbert@redhat.com> + +--- +Originally posted here, context fixed to apply to 3.0/3.1: +[ https://lkml.org/lkml/2011/5/11/548 ] + +diff a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c +--- a/drivers/platform/x86/samsung-laptop.c ++++ b/drivers/platform/x86/samsung-laptop.c +@@ -370,15 +370,17 @@ static u8 read_brightness(void) + &sretval); + if (!retval) { + user_brightness = sretval.retval[0]; +- if (user_brightness != 0) ++ if (user_brightness > sabi_config->min_brightness) + user_brightness -= sabi_config->min_brightness; ++ else ++ user_brightness = 0; + } + return user_brightness; + } + + static void set_brightness(u8 user_brightness) + { +- u8 user_level = user_brightness - sabi_config->min_brightness; ++ u8 user_level = user_brightness + sabi_config->min_brightness; + + sabi_set_command(sabi_config->commands.set_brightness, user_level); + } +@@ -802,7 +804,8 @@ static int __init samsung_init(void) + /* create a backlight device to talk to this one */ + memset(&props, 0, sizeof(struct backlight_properties)); + props.type = BACKLIGHT_PLATFORM; +- props.max_brightness = sabi_config->max_brightness; ++ props.max_brightness = sabi_config->max_brightness - ++ sabi_config->min_brightness; + backlight_device = backlight_device_register("samsung", &sdev->dev, + NULL, &backlight_ops, + &props); +_ |