| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Replaced the use of a manual Makefile with the use of autotools to
automatically verify and generate the necessary build files. Follow the
steps outlined within the README.md file to build the package.
Change-Id: Iaef09f17006ee51ac45f84c6c59826dcc567e279
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I4bb8cf7a58c517f348a524d3e027ebcd1dcd0dea
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Added -Werror to CFLAGS & CXXFLAGS.
Also corrected resulting compiler errors, including commenting out
possible future-use variables.
Change-Id: If70c7fdbf1d02f29e3d2cab5fa12b51bf5302cd5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
A number of arguments to printf were 'size_t', which is the
same size as 'int' only on 32-bit architectures. Replace all
%d format strings with %zd where size_t is the type passed.
Change-Id: Ida863312d692f47ca8240f32b75b8c55a8accc19
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
| |
Improper const was added in 804077 to one of the variables
used as a parameter to mapper_get_service.
Change-Id: I29eeb255794af381c48b505e12a7d68db6d5c54a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sd_bus_message_read(..."s"...) gives a pointer to a char*
from within the message. Even though the message is in
writable memory, it is generally bad to write to the char* from
within it. Also, as a reviewer it is less of a concern to see a
const char* that is lacking a free than it is a char*. Changing to
const char* hopefully avoids the confusion as to why the c-string
does not have a corresponding free.
Eventually this code will likely transition over to the sdbusplus
interfaces and this will be irrelevant.
Change-Id: I0dfe948bb2f0eee03042ba9b9dc7563995f59027
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
| |
Prefer mapper queries to hardcoded busnames.
React to /org/openbmc/managers/system GetObjectById
API change.
Change-Id: I651b820622c3bff51c05365b811b41e73fde997c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|\
| |
| | |
Fixes openbmc/ipmi-fru-parser#3
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPMI fru record format can contain BINARY and ASCII encodings.
There was an error in the way FRU parser was handling the BINARY
encoded data and that resulted in incorrect updates to FRU Inventory object.
The reason why it was done like that was to workaround a limitation
encountered while creating the dictionary having a name and value pair
where value is an array of bytes.
This proposed fix will convert the array of binary encoded data into ascii
string and updates the FRU inventory as a string. Since string is a single
element, it fits in within the limits of dictionary.
Fixes openbmc/ipmi-fru-parser#3
|
|\
| |
| | |
Add shared library versioning
|
| |
| |
| |
| |
| |
| | |
Use -soname and install a library symlink.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
| |
| |
| |
| |
| |
| | |
A couple spaces at the end of line.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|/
|
|
| |
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
| |
Fixes openbmc/ipmi-fru-parser#12.
|
|\
| |
| | |
Using new getFRUOjbect() API to fix 'not found in lookup' error message
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The ipmi-fru-parser calls the dbus method
SystemManager::getObjectFromId('FRU_STR', fru_area_name) for each fru areas
to get the dbus object path of fru area, even if the fru area does not exist.
Also ipmi_validate_fru_area() may be invoked multipul times before
full fru data is parsed. This will generate duplicated error
messages from SystemManager:, e.g:
"ERROR SystemManager: dbus.String(u'INTERNAL_13') not found in lookup".
In this case, "INTERNAL" area does not exists for FRU
In another pull request for skeleton, a new method:
getFRUArea(fru_id) is added specially for ipmi-fru-parser.
See PR: https://github.com/openbmc/skeleton/pull/62.
ipmi-fru-parser gets fru area names defined in Skeleton, and it calls
getObjectFromId() only for fru_aream_name already defined.
This way the 'not found in lookup' error message can be avoided.
Signed-off-by: Yi Li <adamliyi@msn.com>
|
|\ \
| |/
|/| |
Increase size of buffer length variable
|
|/
|
|
|
|
|
|
|
|
|
| |
The latest Barreleye vpd contains additional custom fields in one
of the board sections, pushing the size of the buffer over 0x100.
The current variable that stores the buffer size is set to be
size_t, but the function using it crops it to uint8_t which
doesn't fit the extended size. Changing the function to use size_t.
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|\
| |
| | |
Set Fault and Present status while handling fru
|
|/ |
|
|\
| |
| | |
set present status True after updating inventory
|
|/ |
|
|\
| |
| | |
Makefile not running install correctly
|
|/ |
|
|\
| |
| | |
eeprom read CLI
|
|/ |
|
|\
| |
| | |
Fru write was growing the number of connections on dbus
|
|/ |
|
|
|
|
|
| |
added correct ipmi response buffer
cleaned up a incorrect rc
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Parser has just enough intelligence to parse Chassis, Board & Product
info areas. No support for multi-record in this version.
This parser is a stripped down version of the parser in the FreeIPMI
distribution.
|
|
|