diff options
author | Yann E. MORIN <yann.morin.1998@free.fr> | 2014-04-14 22:47:56 +0200 |
---|---|---|
committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2014-04-14 22:50:24 +0200 |
commit | a89f14e0f1c632393d4dc4bf4518de0b79976edc (patch) | |
tree | d04c5fceff16765f1ef825a1667d3609019300d7 /support/scripts/graph-depends | |
parent | c6f86d593c6875ab99057030a3b27c5490b8eac6 (diff) | |
download | buildroot-a89f14e0f1c632393d4dc4bf4518de0b79976edc.tar.gz buildroot-a89f14e0f1c632393d4dc4bf4518de0b79976edc.zip |
support/graphs: fix comparisons agains None
As Samuel said:
In Python, None is a singleton, and it is recommended to use "is" or
"is not" for testing them [1].
[1] http://legacy.python.org/dev/peps/pep-0008/#programming-recommendations
Reported-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'support/scripts/graph-depends')
-rwxr-xr-x | support/scripts/graph-depends | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends index 4f532ba142..e2a5e1ebf6 100755 --- a/support/scripts/graph-depends +++ b/support/scripts/graph-depends @@ -42,13 +42,13 @@ parser.add_argument("--depth", '-d', metavar="DEPTH", help="Limit the dependency graph to DEPTH levels") args = parser.parse_args() -if args.package == None: +if args.package is None: mode = FULL_MODE else: mode = PKG_MODE rootpkg = args.package -if args.depth != None: +if args.depth is not None: max_depth = int(args.depth) allpkgs = [] @@ -130,7 +130,7 @@ def get_all_depends(pkgs): if len(deps) != 0: newdeps = get_all_depends(deps) - if newdeps != None: + if newdeps is not None: dependencies += newdeps return dependencies @@ -202,7 +202,7 @@ if mode == FULL_MODE: dependencies.append(('all', tg)) filtered_targets.append(tg) deps = get_all_depends(filtered_targets) - if deps != None: + if deps is not None: dependencies += deps rootpkg = 'all' |