diff options
| author | Thomas De Schampheleire <patrickdepinguin@gmail.com> | 2013-12-20 22:31:30 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2013-12-25 12:21:39 +0100 |
| commit | 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf (patch) | |
| tree | fe38a982159d30eeadbc0a30462da1676bdd11b0 /package/nfs-utils | |
| parent | 142a81d60533ef179300c44fd29aaefbfae62d3a (diff) | |
| download | buildroot-35eaed8d07bdc73a83990bc306fcdb08b2e70eaf.tar.gz buildroot-35eaed8d07bdc73a83990bc306fcdb08b2e70eaf.zip | |
Config.in files: use if/endif instead of 'depends on' for main symbol
In the Config.in file of package foo, it often happens that there are other
symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense
when foo itself is enabled. There are two ways to express this: with
depends on BR2_PACKAGE_FOO
in each extra symbol, or with
if BR2_PACKAGE_FOO
...
endif
around the entire set of extra symbols.
The if/endif approach avoids the repetition of 'depends on' statements on
multiple symbols, so this is clearly preferred. But even when there is only
one extra symbol, if/endif is a more logical choice:
- it is future-proof for when extra symbols are added
- it allows to have just one strategy instead of two (less confusion)
This patch modifies the Config.in files accordingly.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/nfs-utils')
| -rw-r--r-- | package/nfs-utils/Config.in | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in index 3602a74f50..dff5150868 100644 --- a/package/nfs-utils/Config.in +++ b/package/nfs-utils/Config.in @@ -1,3 +1,8 @@ +comment "nfs-utils needs a toolchain w/ largefile, threads" + depends on BR2_USE_MMU + depends on !BR2_LARGEFILE || \ + !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC) + config BR2_PACKAGE_NFS_UTILS bool "nfs-utils" depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc @@ -11,30 +16,25 @@ config BR2_PACKAGE_NFS_UTILS http://sourceforge.net/projects/nfs -comment "nfs-utils needs a toolchain w/ largefile, threads" - depends on BR2_USE_MMU - depends on !BR2_LARGEFILE || \ - !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC) +if BR2_PACKAGE_NFS_UTILS menu "NFS utilities selection" - depends on BR2_PACKAGE_NFS_UTILS config BR2_PACKAGE_NFS_UTILS_RPCDEBUG bool "rpcdebug" - depends on BR2_PACKAGE_NFS_UTILS help The RPC debugging utility config BR2_PACKAGE_NFS_UTILS_RPC_LOCKD bool "rpc.lockd" - depends on BR2_PACKAGE_NFS_UTILS help NFS lock manager for Linux kernels older than 2.4 config BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD bool "rpc.rquotad" - depends on BR2_PACKAGE_NFS_UTILS help NFS remote quota server endmenu + +endif |
