diff options
| author | Thomas De Schampheleire <patrickdepinguin@gmail.com> | 2013-12-20 22:31:30 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2013-12-25 12:21:39 +0100 |
| commit | 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf (patch) | |
| tree | fe38a982159d30eeadbc0a30462da1676bdd11b0 /package/netsnmp | |
| parent | 142a81d60533ef179300c44fd29aaefbfae62d3a (diff) | |
| download | buildroot-35eaed8d07bdc73a83990bc306fcdb08b2e70eaf.tar.gz buildroot-35eaed8d07bdc73a83990bc306fcdb08b2e70eaf.zip | |
Config.in files: use if/endif instead of 'depends on' for main symbol
In the Config.in file of package foo, it often happens that there are other
symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense
when foo itself is enabled. There are two ways to express this: with
depends on BR2_PACKAGE_FOO
in each extra symbol, or with
if BR2_PACKAGE_FOO
...
endif
around the entire set of extra symbols.
The if/endif approach avoids the repetition of 'depends on' statements on
multiple symbols, so this is clearly preferred. But even when there is only
one extra symbol, if/endif is a more logical choice:
- it is future-proof for when extra symbols are added
- it allows to have just one strategy instead of two (less confusion)
This patch modifies the Config.in files accordingly.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/netsnmp')
| -rw-r--r-- | package/netsnmp/Config.in | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/package/netsnmp/Config.in b/package/netsnmp/Config.in index 3d089362f4..8edbd39446 100644 --- a/package/netsnmp/Config.in +++ b/package/netsnmp/Config.in @@ -7,10 +7,11 @@ config BR2_PACKAGE_NETSNMP http://net-snmp.sourceforge.net/ +if BR2_PACKAGE_NETSNMP + config BR2_PACKAGE_NETSNMP_ENABLE_MIBS bool "Install MIB files on target and enable MIB loading code" default y - depends on BR2_PACKAGE_NETSNMP help The net-snmp package contains a selection of MIB files. Say yes if you want those MIB files installed on the target @@ -19,22 +20,21 @@ config BR2_PACKAGE_NETSNMP_ENABLE_MIBS config BR2_PACKAGE_NETSNMP_WITH_MIB_MODULES string "Build with these MIB modules" default "host ucd-snmp/dlmod agentx" - depends on BR2_PACKAGE_NETSNMP help Specify which MIB modules to include. config BR2_PACKAGE_NETSNMP_WITHOUT_MIB_MODULES string "Build without these MIB modules" default "disman/event disman/schedule utilities" - depends on BR2_PACKAGE_NETSNMP help Specify which MIB modules to exclude. config BR2_PACKAGE_NETSNMP_ENABLE_DEBUGGING bool "Enable debugging code" - depends on BR2_PACKAGE_NETSNMP help By default net-snmp is compiled without debugging support (--disable-debugging). Enable this options if you need debugging support, including the ability to log with DEBUGMSG(), DEBUGMSGTL() and companion macros. + +endif |
