summaryrefslogtreecommitdiffstats
path: root/package/dropbear
diff options
context:
space:
mode:
authorStefan Sørensen <stefan.sorensen@spectralink.com>2018-05-07 14:28:43 +0200
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>2018-05-08 15:09:25 +0200
commitc9922a4d2fc79e1d17f85e6f74c1e6ece9c91092 (patch)
treee17d3e7c85fb9fc6e01abb125ac1ed3037915106 /package/dropbear
parent0998275a3ad679b8410ec67ad14b4eb356574904 (diff)
downloadbuildroot-c9922a4d2fc79e1d17f85e6f74c1e6ece9c91092.tar.gz
buildroot-c9922a4d2fc79e1d17f85e6f74c1e6ece9c91092.zip
dropbear: Do not build static binary
Dropbear 2018.76 now uses the --enable-static option to indicate that a static binary should be built. This will incorrectly pick up the generic buildroot option intended for building static libraries, causing an unwanted static binary build with BR2_SHARED_STATIC_LIBS. Fix by appending an --disable-static configure flag, overriding the buildroot default. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> Reviewed-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Diffstat (limited to 'package/dropbear')
-rw-r--r--package/dropbear/dropbear.mk7
1 files changed, 5 insertions, 2 deletions
diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
index 1da1a559a3..fc41a84c1f 100644
--- a/package/dropbear/dropbear.mk
+++ b/package/dropbear/dropbear.mk
@@ -27,8 +27,11 @@ DROPBEAR_MAKE = \
$(MAKE) MULTI=1 SCPPROGRESS=1 \
PROGRAMS="$(DROPBEAR_PROGRAMS)"
-ifeq ($(BR2_STATIC_LIBS),y)
-DROPBEAR_CONF_OPTS += --enable-static
+# With BR2_SHARED_STATIC_LIBS=y the generic infrastructure adds a
+# --enable-static flags causing dropbear to be built as a static
+# binary. Adding a --disable-static reverts this
+ifeq ($(BR2_SHARED_STATIC_LIBS),y)
+DROPBEAR_CONF_OPTS += --disable-static
endif
# Ensure that dropbear doesn't use crypt() when it's not available
OpenPOWER on IntegriCloud