diff options
| author | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2015-09-02 00:01:03 +0200 |
|---|---|---|
| committer | Peter Korsgaard <peter@korsgaard.com> | 2015-09-10 13:47:00 +0200 |
| commit | 113dc8f35a8be183d8eff365f8ee6fd8cc467590 (patch) | |
| tree | f934a55bd72fbc5dcdad285d0c54880b852eca16 /package/directfb | |
| parent | 3f0bed19ffee4767ddfb32e2e791ecbc6b7e78b7 (diff) | |
| download | buildroot-113dc8f35a8be183d8eff365f8ee6fd8cc467590.tar.gz buildroot-113dc8f35a8be183d8eff365f8ee6fd8cc467590.zip | |
directfb: mark as available only for gcc >= 4.5
The new DirectFB version does not build with gcc 4.3 from the Blackfin
toolchain. One of the reason is that va_copy has some issues, which
were fixed in gcc 4.4.0
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36799). There are also
some other issues, which were fixed by a patch proposed by Peter
Seiderer at
http://lists.busybox.net/pipermail/buildroot/2015-February/120281.html.
However, it probably doesn't make a lot of sense to carry patches that
are not upstream for such old compilers. Instead, this commit takes
the action of making DirectFB available only on toolchains using gcc
>= 4.5, which was tested with the Arago toolchain. gcc 4.4 could
potentially work, but wasn't tested (it is no longer supported by the
internal toolchain backend, and we don't have any toolchain based on
gcc 4.4), so we take the safe decision of requiring at least gcc 4.5.
[Peter: add comment explaining toolchain dependenc as suggested by Vincente]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Diffstat (limited to 'package/directfb')
| -rw-r--r-- | package/directfb/Config.in | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/package/directfb/Config.in b/package/directfb/Config.in index 2b0d5c75a1..3ab40f98dc 100644 --- a/package/directfb/Config.in +++ b/package/directfb/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_DIRECTFB bool "directfb" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 select BR2_PACKAGE_FREETYPE select BR2_PACKAGE_ZLIB help @@ -157,5 +158,5 @@ config BR2_PACKAGE_DIRECTFB_TESTS endif # BR2_PACKAGE_DIRECTFB -comment "directfb needs a toolchain w/ C++, threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP +comment "directfb needs a toolchain w/ C++, threads, gcc >= 4.5" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 |
