diff options
| author | Ed Tanous <ed.tanous@intel.com> | 2019-09-18 16:03:55 +0000 |
|---|---|---|
| committer | Ed Tanous <ed.tanous@intel.com> | 2019-09-18 16:51:38 +0000 |
| commit | 88e097c4cfa1172504d802e9f6b327f095f2748e (patch) | |
| tree | 71fc3578194fe9cf31041a8d88c084d8ec3827bd | |
| parent | 73de092f524d28f1002fe76577603007331896a3 (diff) | |
| download | bmcweb-88e097c4cfa1172504d802e9f6b327f095f2748e.tar.gz bmcweb-88e097c4cfa1172504d802e9f6b327f095f2748e.zip | |
Revert "Fix remove callback user privilege access to login"
This reverts commit 8e69d148249f6a45cea10e988ec03430a5932784.
Reason for revert: This causes service validator failures.
I missed the fact that despite being asked a couple times, the service validator wasn't run. Please run it, resolve your bug, and resubmit as a new review.
Change-Id: I0bb61ab1a618a96b2ed2c600825ec72b8d020ec0
| -rw-r--r-- | redfish-core/include/privileges.hpp | 8 | ||||
| -rw-r--r-- | redfish-core/lib/roles.hpp | 2 |
2 files changed, 2 insertions, 8 deletions
diff --git a/redfish-core/include/privileges.hpp b/redfish-core/include/privileges.hpp index 113f66a..ec6e6a5 100644 --- a/redfish-core/include/privileges.hpp +++ b/redfish-core/include/privileges.hpp @@ -192,18 +192,12 @@ inline const Privileges& getUserPrivileges(const std::string& userRole) static Privileges op{"Login", "ConfigureSelf", "ConfigureComponents"}; return op; } - else if (userRole == "priv-user") + else { // Redfish privilege : Readonly static Privileges readOnly{"Login", "ConfigureSelf"}; return readOnly; } - else - { - // Redfish Privilege : No privileges for callback users - static Privileges noPriv{}; - return noPriv; - } } using OperationMap = boost::container::flat_map<boost::beast::http::verb, diff --git a/redfish-core/lib/roles.hpp b/redfish-core/lib/roles.hpp index 956f566..fbe8653 100644 --- a/redfish-core/lib/roles.hpp +++ b/redfish-core/lib/roles.hpp @@ -61,7 +61,7 @@ inline bool getAssignedPrivFromRole(std::string_view role, } else if (role == "Callback") { - privArray = {}; + privArray = {"Login"}; } else { |

