summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEd Tanous <ed.tanous@intel.com>2019-06-20 08:21:51 -0700
committerEd Tanous <ed.tanous@intel.com>2019-06-20 08:21:51 -0700
commit00a5eddc7bb95cd5654988156dd61c0bd89c425f (patch)
treee0d30cff686bfb301917e34a09d272aade006a7d
parent34dd179e402364ff94b697cf16d4dd99e49541f3 (diff)
downloadbmcweb-00a5eddc7bb95cd5654988156dd61c0bd89c425f.tar.gz
bmcweb-00a5eddc7bb95cd5654988156dd61c0bd89c425f.zip
Remove pulling BiosID for the system schema
This is causing 500 errors on POWER platforms, given that (shocker) they don't have a BIOS! In practice, this isn't even the right way to grab the version information, we should be grabbing it over the software version interface https://github.com/openbmc/phosphor-dbus-interfaces /blob/master/xyz/openbmc_project/Software/Version.interface.yaml Signed-off-by: Ed Tanous <ed.tanous@intel.com> Change-Id: I45704b879a57d152c898594770e8d3729ad9e72e
-rw-r--r--redfish-core/lib/systems.hpp21
1 files changed, 0 insertions, 21 deletions
diff --git a/redfish-core/lib/systems.hpp b/redfish-core/lib/systems.hpp
index fc13803..0821cc9 100644
--- a/redfish-core/lib/systems.hpp
+++ b/redfish-core/lib/systems.hpp
@@ -1191,27 +1191,6 @@ class Systems : public Node
};
auto asyncResp = std::make_shared<AsyncResp>(res);
- crow::connections::systemBus->async_method_call(
- [asyncResp](const boost::system::error_code ec,
- const VariantType &biosId) {
- if (ec)
- {
- BMCWEB_LOG_ERROR << ec;
- messages::internalError(asyncResp->res);
- return;
- }
- const std::string *strBiosId =
- std::get_if<std::string>(&biosId);
- if (strBiosId != nullptr)
- {
- BMCWEB_LOG_DEBUG << "bios ver. = " << strBiosId;
- asyncResp->res.jsonValue["BiosVersion"] = *strBiosId;
- }
- },
- "xyz.openbmc_project.Settings", "/xyz/openbmc_project/bios",
- "org.freedesktop.DBus.Properties", "Get",
- "xyz.openbmc_project.Inventory.Item.Bios", "BiosId");
-
getMainChassisId(asyncResp, [](const std::string &chassisId,
std::shared_ptr<AsyncResp> aRsp) {
aRsp->res.jsonValue["Links"]["Chassis"] = {
OpenPOWER on IntegriCloud