diff options
author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-11-17 19:04:08 +1100 |
---|---|---|
committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-11-18 08:40:26 +1100 |
commit | 3a3ee531dd3bdb3aec51bce3b4880da25e46af40 (patch) | |
tree | cc02d1191932c69e7c21da397b15647cb30446b0 /include | |
parent | 916196d4cc0e070369ff6aa1363fa39339f8cad1 (diff) | |
download | blackbird-skiboot-3a3ee531dd3bdb3aec51bce3b4880da25e46af40.tar.gz blackbird-skiboot-3a3ee531dd3bdb3aec51bce3b4880da25e46af40.zip |
fsp/fsp-rtc: Correctly report back errors to host
When we got FSP_STATUS_TOD_RESET or similar, we would return OPAL_BUSY
which would cause the Linux OPAL RTC driver to retry in a loop until
we didn't say we're busy.
The problem with this is that some errors, such as FSP_STATUS_TOD_RESET
are, in fact, permanent until we (say) set the time explicitly, so no
matter how hard that little linux driver tries, it's never going to
break out of that loop.
This fix is to fix our use of the state machine introduced way back in
6cf8b663e7d7cb1e827b6d9c90e694ea583f6f87 so that we return an error code
to linux.
Reported-by: Cédric Le Goater <clg@fr.ibm.com>
Fixes: 6cf8b663e7d7cb1e827b6d9c90e694ea583f6f87
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Reviewed-by: Cédric Le Goater <clg@fr.ibm.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions