summaryrefslogtreecommitdiffstats
path: root/hw/lpc-mbox.c
diff options
context:
space:
mode:
authorCyril Bur <cyril.bur@au1.ibm.com>2017-12-05 12:01:05 +1100
committerStewart Smith <stewart@linux.vnet.ibm.com>2017-12-14 23:58:38 -0600
commitf47de2b05f9dcda78df6b8717956fa8f23bcc22f (patch)
tree3f6682d1516b861011ec26831586af51ec1fa322 /hw/lpc-mbox.c
parent3e6c3b03bb4cc5d088fc3da7293274adaabf6c5c (diff)
downloadblackbird-skiboot-f47de2b05f9dcda78df6b8717956fa8f23bcc22f.tar.gz
blackbird-skiboot-f47de2b05f9dcda78df6b8717956fa8f23bcc22f.zip
libflash/mbox-flash: Move sequence handling to driver level
Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/lpc-mbox.c')
-rw-r--r--hw/lpc-mbox.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/hw/lpc-mbox.c b/hw/lpc-mbox.c
index 7a57f1e7..74214938 100644
--- a/hw/lpc-mbox.c
+++ b/hw/lpc-mbox.c
@@ -63,6 +63,7 @@ struct mbox {
void *attn_data;
struct lock lock; /* Protect in_flight */
struct bmc_mbox_msg *in_flight;
+ uint8_t sequence;
};
static struct mbox mbox;
@@ -130,6 +131,7 @@ int bmc_mbox_enqueue(struct bmc_mbox_msg *msg)
mbox.in_flight = msg;
unlock(&mbox.lock);
+ msg->seq = ++mbox.sequence;
bmc_mbox_send_message(msg);
@@ -162,7 +164,13 @@ static void mbox_poll(struct timer *t __unused, void *data __unused,
prlog(PR_CRIT, "Couldn't find the message!!\n");
goto out_response;
}
+
bmc_mbox_recv_message(msg);
+ if (mbox.sequence != msg->seq) {
+ prlog(PR_ERR, "Got a response to a message we no longer care about\n");
+ goto out_response;
+ }
+
if (mbox.callback)
mbox.callback(msg, mbox.drv_data);
else
@@ -330,6 +338,7 @@ void mbox_init(void)
mbox.in_flight = NULL;
mbox.callback = NULL;
mbox.drv_data = NULL;
+ mbox.sequence = 0;
init_lock(&mbox.lock);
init_timer(&mbox.poller, mbox_poll, NULL);
OpenPOWER on IntegriCloud