diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-02-06 16:25:52 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-02-06 16:25:52 +1100 |
| commit | 7d8a8ebe7e5f99ce230e5c92b3fd832ab43cd5b5 (patch) | |
| tree | 796a8036b9c54afd500fdca5851a50bf4f1bd50f /hw/fsp/fsp-mdst-table.c | |
| parent | d195fd680eac1044681fd265edfbf342888f4a93 (diff) | |
| download | blackbird-skiboot-7d8a8ebe7e5f99ce230e5c92b3fd832ab43cd5b5.tar.gz blackbird-skiboot-7d8a8ebe7e5f99ce230e5c92b3fd832ab43cd5b5.zip | |
Fix unsupported return code of OPAL_(UN)REGISTER_DUMP_REGION
Linux has been expecting OPAL_REGISTER_DUMP_REGION and
OPAL_UNREGISTER_DUMP_REGION to return OPAL_UNSUPPORTED in the event of
the call being supported on the platform (that is, the OPAL_CHECK_TOKEN
result is OPAL_TOKEN_PRESENT) but for some reason dump regions weren't
supported.
This only ever managed to be the case on P7 machines in the lab, so
it's not going to break anything that skiboot now returns the expected
result rather than OPAL_SUCCESS - which is completely the wrong thing
to return.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp/fsp-mdst-table.c')
| -rw-r--r-- | hw/fsp/fsp-mdst-table.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/hw/fsp/fsp-mdst-table.c b/hw/fsp/fsp-mdst-table.c index 318c6b01..f27c1b38 100644 --- a/hw/fsp/fsp-mdst-table.c +++ b/hw/fsp/fsp-mdst-table.c @@ -292,11 +292,11 @@ static int64_t fsp_opal_register_dump_region(uint32_t id, int rc = OPAL_SUCCESS; if (!fsp_present()) - return rc; + return OPAL_UNSUPPORTED; if (!fsp_mdst_supported()) { printf("MDST: Not supported\n"); - return rc; + return OPAL_UNSUPPORTED; } /* Validate memory region id */ @@ -327,11 +327,11 @@ static int64_t fsp_opal_unregister_dump_region(uint32_t id) int rc = OPAL_SUCCESS; if (!fsp_present()) - return rc; + return OPAL_UNSUPPORTED; if (!fsp_mdst_supported()) { printf("MDST: Not supported\n"); - return rc; + return OPAL_UNSUPPORTED; } /* Validate memory region id */ |
