diff options
author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2016-09-15 09:52:32 +0800 |
---|---|---|
committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-09-16 16:21:45 +1000 |
commit | 925f03c184f42104a1ebd676f4d3c3d50b8a44b8 (patch) | |
tree | bc8aef4cea03564ab8bfd1aadb15f50d3382fcfd /external/opal-prd/hostboot-interface.h | |
parent | 3d41d2831a05d531f152e0f9c7fc223a82aee128 (diff) | |
download | blackbird-skiboot-925f03c184f42104a1ebd676f4d3c3d50b8a44b8.tar.gz blackbird-skiboot-925f03c184f42104a1ebd676f4d3c3d50b8a44b8.zip |
opal-prd: Fix error code from scom_read & scom_write
Currently, we always return a zero value from scom_read & scom_write,
so the HBRT implementation has no way of detecting errors during scom
operations.
This change uses the actual return value from the scom operation from
the kernel instead.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'external/opal-prd/hostboot-interface.h')
-rw-r--r-- | external/opal-prd/hostboot-interface.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/external/opal-prd/hostboot-interface.h b/external/opal-prd/hostboot-interface.h index 36d53a6b..3e73ef8e 100644 --- a/external/opal-prd/hostboot-interface.h +++ b/external/opal-prd/hostboot-interface.h @@ -46,6 +46,14 @@ enum MemoryError_t #define HBRT_CAPS_SET1_OPAL 1 #define HBRT_CAPS_SET2_PHYP 2 +/* Capability flags */ + +/** + * xscom_read and xscom_write return proper return codes on error. + * Previous implementations may have incorrectly ignored failures. + */ +#define HBRT_CAPS_OPAL_HAS_XSCOM_RC (1ul << 0) + struct host_interfaces { /** Interface version. */ uint64_t interface_version; |