summaryrefslogtreecommitdiffstats
path: root/core/opal.c
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.ibm.com>2018-11-29 15:28:29 +1100
committerStewart Smith <stewart@linux.ibm.com>2018-12-10 22:21:12 -0600
commit0714735f0b8513dad808650291f377bd617d5951 (patch)
tree7847dba94321d8f447ef6b0e53bf2ed99b3498cd /core/opal.c
parent685f0786a93528b24c73771b643a6183d4fd16dc (diff)
downloadblackbird-skiboot-0714735f0b8513dad808650291f377bd617d5951.tar.gz
blackbird-skiboot-0714735f0b8513dad808650291f377bd617d5951.zip
opal_trace_entry: Move ifdef around to shut up static analysis
Again, this makes things look slightly different so I don't keep seeing the static analysis warning. Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'core/opal.c')
-rw-r--r--core/opal.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/core/opal.c b/core/opal.c
index 3a8ea30b..ba30c309 100644
--- a/core/opal.c
+++ b/core/opal.c
@@ -93,9 +93,9 @@ long opal_bad_token(uint64_t token)
return OPAL_PARAMETER;
}
+#ifdef OPAL_TRACE_ENTRY
static void opal_trace_entry(struct stack_frame *eframe __unused)
{
-#ifdef OPAL_TRACE_ENTRY
union trace t;
unsigned nargs, i;
@@ -111,8 +111,8 @@ static void opal_trace_entry(struct stack_frame *eframe __unused)
t.opal.r3_to_11[i] = cpu_to_be64(eframe->gpr[3+i]);
trace_add(&t, TRACE_OPAL, offsetof(struct trace_opal, r3_to_11[nargs]));
-#endif
}
+#endif
/*
* opal_quiesce_state is used as a lock. Don't use an actual lock to avoid
@@ -138,7 +138,9 @@ int64_t opal_entry_check(struct stack_frame *eframe)
abort();
}
+#ifdef OPAL_TRACE_ENTRY
opal_trace_entry(eframe);
+#endif
if (!opal_check_token(token))
return opal_bad_token(token);
OpenPOWER on IntegriCloud