summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.ibm.com>2019-03-18 16:52:19 +1100
committerStewart Smith <stewart@linux.ibm.com>2019-03-20 14:27:08 +1100
commitbee7be6ab780a3bf51feb66a8a86cb9ff1bd7775 (patch)
treec6305653cd33128bf634ffc7106dd889abd66506
parenta2c13f1d6119004a4a1a4adbbbf773275282236d (diff)
downloadblackbird-skiboot-bee7be6ab780a3bf51feb66a8a86cb9ff1bd7775.tar.gz
blackbird-skiboot-bee7be6ab780a3bf51feb66a8a86cb9ff1bd7775.zip
hdata: Prevent NULL dereference on duplicate slot map info
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
-rw-r--r--hdata/iohub.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/hdata/iohub.c b/hdata/iohub.c
index ad1ddae4..028fc6ab 100644
--- a/hdata/iohub.c
+++ b/hdata/iohub.c
@@ -660,6 +660,10 @@ static void parse_one_slot(const struct slot_map_entry *entry,
case st_rc_slot:
node = dt_new_2addr(dt_slots, "root-complex",
chip_id, entry->phb_index);
+ if (!node) {
+ SM_ERR("Couldn't add DT node\n");
+ return;
+ }
dt_add_property_cells(node, "reg", chip_id, entry->phb_index);
dt_add_property_cells(node, "#address-cells", 2);
dt_add_property_cells(node, "#size-cells", 0);
OpenPOWER on IntegriCloud