summaryrefslogtreecommitdiffstats
path: root/sound/pci/emu10k1/emu10k1_callback.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2012-10-08 19:13:01 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2012-10-09 06:53:20 +0900
commitd5bbd43d5f450c3fca058f5b85f3dfb4e8cc88c9 (patch)
tree9ee712ea3c2768dc9934e1e6003680793f303a00 /sound/pci/emu10k1/emu10k1_callback.c
parentb5356a19ced273ef8a941be226f4dfdb95c23073 (diff)
downloadblackbird-op-linux-d5bbd43d5f450c3fca058f5b85f3dfb4e8cc88c9.tar.gz
blackbird-op-linux-d5bbd43d5f450c3fca058f5b85f3dfb4e8cc88c9.zip
exec: make de_thread() killable
Change de_thread() to use KILLABLE rather than UNINTERRUPTIBLE while waiting for other threads. The only complication is that we should clear ->group_exit_task and ->notify_count before we return, and we should do this under tasklist_lock. -EAGAIN is used to match the initial signal_group_exit() check/return, it doesn't really matter. This fixes the (unlikely) race with coredump. de_thread() checks signal_group_exit() before it starts to kill the subthreads, but this can't help if another CLONE_VM (but non CLONE_THREAD) task starts the coredumping after de_thread() unlocks ->siglock. In this case the killed sub-thread can block in exit_mm() waiting for coredump_finish(), execing thread waits for that sub-thead, and the coredumping thread waits for execing thread. Deadlock. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/pci/emu10k1/emu10k1_callback.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud