summaryrefslogtreecommitdiffstats
path: root/samples
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-10-18 04:11:14 +0000
committerDavid S. Miller <davem@davemloft.net>2010-10-21 04:25:50 -0700
commit13eea19213c1f4b711124ddc08c4bb9344442b64 (patch)
tree83032b178c6cc9a4c7a40f87be6b3da1decd6bb1 /samples
parentafed4ccb0d975f1d3c98880ecf19a24f3d842394 (diff)
downloadblackbird-op-linux-13eea19213c1f4b711124ddc08c4bb9344442b64.tar.gz
blackbird-op-linux-13eea19213c1f4b711124ddc08c4bb9344442b64.zip
drivers/net/ax88796.c: Return error code in failure
In this code, 0 is returned on failure, even though other failures return -ENOMEM or other similar values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @a@ identifier alloc; identifier ret; constant C; expression x; @@ x = alloc(...); if (x == NULL) { <+... \(ret = -C; \| return -C; \) ...+> } @@ identifier f, a.alloc; expression ret; expression x,e1,e2,e3; @@ ret = 0 ... when != ret = e1 *x = alloc(...) ... when != ret = e2 if (x == NULL) { ... when != ret = e3 return ret; } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud