summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-10-12 12:14:29 +0300
committerPablo Neira Ayuso <pablo@netfilter.org>2016-10-17 17:43:53 +0200
commit09525a09ad3099efd9ba49b0b90bddc350d6b53a (patch)
treedc43e492d23803c86071082981d33ef7094fc5f7 /net
parent5751e175c60be1b4113d1e9bfa011b58ec01f104 (diff)
downloadblackbird-op-linux-09525a09ad3099efd9ba49b0b90bddc350d6b53a.tar.gz
blackbird-op-linux-09525a09ad3099efd9ba49b0b90bddc350d6b53a.zip
netfilter: nf_tables: underflow in nft_parse_u32_check()
We don't want to allow negatives here. Fixes: 36b701fae12a ('netfilter: nf_tables: validate maximum value of u32 netlink attributes') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/nf_tables_api.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index b70d3ea1430e..24db22257586 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -4423,7 +4423,7 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx,
*/
unsigned int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest)
{
- int val;
+ u32 val;
val = ntohl(nla_get_be32(attr));
if (val > max)
OpenPOWER on IntegriCloud