diff options
author | Nazarov Sergey <s-nazarov@yandex.ru> | 2019-02-25 19:27:15 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-02-25 14:32:35 -0800 |
commit | 3da1ed7ac398f34fff1694017a07054d69c5f5c5 (patch) | |
tree | ac42a19c628b81052191fa63e832e3aca6b84df2 /net/ipv4/ip_options.c | |
parent | 9ef6b42ad6fd7929dd1b6092cb02014e382c6a91 (diff) | |
download | blackbird-op-linux-3da1ed7ac398f34fff1694017a07054d69c5f5c5.tar.gz blackbird-op-linux-3da1ed7ac398f34fff1694017a07054d69c5f5c5.zip |
net: avoid use IPCB in cipso_v4_error
Extract IP options in cipso_v4_error and use __icmp_send.
Signed-off-by: Sergey Nazarov <s-nazarov@yandex.ru>
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_options.c')
-rw-r--r-- | net/ipv4/ip_options.c | 22 |
1 files changed, 17 insertions, 5 deletions
diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c index ed194d46c00e..32a35043c9f5 100644 --- a/net/ipv4/ip_options.c +++ b/net/ipv4/ip_options.c @@ -251,8 +251,9 @@ static void spec_dst_fill(__be32 *spec_dst, struct sk_buff *skb) * If opt == NULL, then skb->data should point to IP header. */ -int ip_options_compile(struct net *net, - struct ip_options *opt, struct sk_buff *skb) +int __ip_options_compile(struct net *net, + struct ip_options *opt, struct sk_buff *skb, + __be32 *info) { __be32 spec_dst = htonl(INADDR_ANY); unsigned char *pp_ptr = NULL; @@ -468,11 +469,22 @@ eol: return 0; error: - if (skb) { - icmp_send(skb, ICMP_PARAMETERPROB, 0, htonl((pp_ptr-iph)<<24)); - } + if (info) + *info = htonl((pp_ptr-iph)<<24); return -EINVAL; } + +int ip_options_compile(struct net *net, + struct ip_options *opt, struct sk_buff *skb) +{ + int ret; + __be32 info; + + ret = __ip_options_compile(net, opt, skb, &info); + if (ret != 0 && skb) + icmp_send(skb, ICMP_PARAMETERPROB, 0, info); + return ret; +} EXPORT_SYMBOL(ip_options_compile); /* |