summaryrefslogtreecommitdiffstats
path: root/net/ipv4/icmp.c
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2005-08-09 20:02:13 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2005-08-29 15:38:54 -0700
commita86888b925299330053d20e0eba03ac4d2648c4b (patch)
tree27c2d22d98a9eed22749df1a8d32f72e1b5a2468 /net/ipv4/icmp.c
parenta55ebcc4c4532107ad9eee1c9bb698ab5f12c00f (diff)
downloadblackbird-op-linux-a86888b925299330053d20e0eba03ac4d2648c4b.tar.gz
blackbird-op-linux-a86888b925299330053d20e0eba03ac4d2648c4b.zip
[NETFILTER]: Fix multiple problems with the conntrack event cache
refcnt underflow: the reference count is decremented when a conntrack entry is removed from the hash but it is not incremented when entering new entries. missing protection of process context against softirq context: all cache operations need to locally disable softirqs to avoid races. Additionally the event cache can't be initialized when a packet enteres the conntrack code but needs to be initialized whenever we cache an event and the stored conntrack entry doesn't match the current one. incorrect flushing of the event cache in ip_ct_iterate_cleanup: without real locking we can't flush the cache for different CPUs without incurring races. The cache for different CPUs can only be flushed when no packets are going through the code. ip_ct_iterate_cleanup doesn't need to drop all references, so flushing is moved to the cleanup path. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/icmp.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud