diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-18 20:10:34 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-11-19 15:20:15 -0500 |
| commit | ef87c5d6a11af45c31910728e46642e77aa8db61 (patch) | |
| tree | af0166e2faceb59be601973c3facd169aff3e8f0 /net/core | |
| parent | 1abe7cd91a994a214650d7dec0bd03e6ebc95913 (diff) | |
| download | blackbird-op-linux-ef87c5d6a11af45c31910728e46642e77aa8db61.tar.gz blackbird-op-linux-ef87c5d6a11af45c31910728e46642e77aa8db61.zip | |
net: pktgen: Deletion of an unnecessary check before the function call "proc_remove"
The proc_remove() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/pktgen.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 443256bdcddc..da934fc3faa8 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -3728,8 +3728,7 @@ static int pktgen_remove_device(struct pktgen_thread *t, /* Remove proc before if_list entry, because add_device uses * list to determine if interface already exist, avoid race * with proc_create_data() */ - if (pkt_dev->entry) - proc_remove(pkt_dev->entry); + proc_remove(pkt_dev->entry); /* And update the thread if_list */ _rem_dev_from_if_list(t, pkt_dev); |
