summaryrefslogtreecommitdiffstats
path: root/net/bridge
diff options
context:
space:
mode:
authorNishanth Menon <nm@ti.com>2016-02-19 18:09:51 -0600
committerGuenter Roeck <linux@roeck-us.net>2016-02-19 17:14:25 -0800
commit000e0949148382c4962489593a2f05504c2a6771 (patch)
tree0d4ae71256666f3f785bbae7e9f98bf89dab9ccf /net/bridge
parentacc146943957d7418a6846f06e029b2c5e87e0d5 (diff)
downloadblackbird-op-linux-000e0949148382c4962489593a2f05504c2a6771.tar.gz
blackbird-op-linux-000e0949148382c4962489593a2f05504c2a6771.zip
hwmon: (gpio-fan) Remove un-necessary speed_index lookup for thermal hook
Thermal hook gpio_fan_get_cur_state is only interested in knowing the current speed index that was setup in the system, this is already available as part of fan_data->speed_index which is always set by set_fan_speed. Using get_fan_speed_index is useful when we have no idea about the fan speed configuration (for example during fan_ctrl_init). When thermal framework invokes gpio_fan_get_cur_state=>get_fan_speed_index via gpio_fan_get_cur_state especially in a polled configuration for thermal governor, we basically hog the i2c interface to the extent that other functions fail to get any traffic out :(. Instead, just provide the last state set in the driver - since the gpio fan driver is responsible for the fan state immaterial of override, the fan_data->speed_index should accurately reflect the state. Fixes: b5cf88e46bad ("(gpio-fan): Add thermal control hooks") Reported-by: Tony Lindgren <tony@atomide.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Nishanth Menon <nm@ti.com> Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'net/bridge')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud